chore(deps): update dependency electron-playwright-helpers to v2#766
chore(deps): update dependency electron-playwright-helpers to v2#766renovate[bot] wants to merge 2 commits into
Conversation
43307d6 to
a0d52e4
Compare
|
@claude The Renovate PR build failed (workflow run: 20620445090). Please analyze the CI failure and implement a fix if possible. Workflow run: https://github.com/olexs/pdf-assembler/actions/runs/20620445090 |
|
Claude finished @olexs's task in 4m 56s —— View job Analysis Complete ✓ProblemThe Windows E2E tests were failing with timeouts:
All failures occurred while waiting for Root CauseThe Solution ImplementedStore the page reference from Changes Made let electronApp: ElectronApplication;
let appInfo: ElectronAppInfo;
+let currentPage: Page;
async function launchApp(...args: string[]): Promise<Page> {
// ... existing code ...
- return electronApp.firstWindow();
+ currentPage = await electronApp.firstWindow();
+ return currentPage;
}
test.afterEach(async () => {
// Clear localStorage to prevent state poisoning between tests
- const page = await electronApp.firstWindow();
- await page.evaluate(() => {
+ // Use the stored page reference instead of calling firstWindow() again
+ await currentPage.evaluate(() => {
localStorage.clear();
});Pre-commit Checks
StatusI've prepared the fix and created a commit locally, but I don't have push permissions to update this PR branch. You'll need to apply this change manually or grant push permissions. To apply the fix, either:
The fix is minimal and targeted - it simply caches the page reference to avoid race conditions with the new retry behavior in electron-playwright-helpers v2.0. --- | Branch |
a0d52e4 to
b373498
Compare
611cf50 to
ef60f77
Compare
ef60f77 to
f91438d
Compare
|
@claude The Renovate PR build failed (workflow run: 21602407722). Please analyze the CI failure and implement a fix if possible. Workflow run: https://github.com/olexs/pdf-assembler/actions/runs/21602407722 |
|
Claude finished @olexs's task in 2m 58s —— View job Analysis Complete ✓Todo List:
ProblemAll E2E tests were timing out on both Windows and macOS at line 170 ( Root CauseThe Solution ImplementedStore the page reference from Changes Made let electronApp: ElectronApplication;
let appInfo: ElectronAppInfo;
+let currentPage: Page;
async function launchApp(...args: string[]): Promise<Page> {
// ... existing code ...
- return electronApp.firstWindow();
+ currentPage = await electronApp.firstWindow();
+ return currentPage;
}
test.afterEach(async () => {
// Clear localStorage to prevent state poisoning between tests
- const page = await electronApp.firstWindow();
- await page.evaluate(() => {
+ // Use the stored page reference instead of calling firstWindow() again
+ await currentPage.evaluate(() => {
localStorage.clear();
});Pre-commit Checks
StatusFix has been committed and pushed to the PR branch. The CI will now run E2E tests to verify the fix resolves the timeout issues on both Windows and macOS. --- | Branch |
…compatibility In electron-playwright-helpers v2, calling firstWindow() during window lifecycle events can fail or return incorrect references due to changes in retry/error handling. Store the page reference from launchApp() in a module variable and reuse it in afterEach to avoid race conditions. Co-authored-by: Olex S. <olexs@users.noreply.github.com>
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
1.8.2→2.1.0Release Notes
spaceagetv/electron-playwright-helpers (electron-playwright-helpers)
v2.1.0Compare Source
Features
v2.0.1Compare Source
v2.0.0Compare Source
Bug Fixes
Features
BREAKING CHANGES
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.