Skip to content

chore(deps): update actions/upload-artifact action to v7#764

Open
renovate[bot] wants to merge 2 commits into
masterfrom
renovate/major-github-artifact-actions
Open

chore(deps): update actions/upload-artifact action to v7#764
renovate[bot] wants to merge 2 commits into
masterfrom
renovate/major-github-artifact-actions

Conversation

@renovate

@renovate renovate Bot commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
actions/upload-artifact action major v5v7

Release Notes

actions/upload-artifact (actions/upload-artifact)

v7

Compare Source

v6

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate Bot force-pushed the renovate/major-github-artifact-actions branch from ff6fb92 to d5dd161 Compare December 15, 2025 18:39
@renovate renovate Bot force-pushed the renovate/major-github-artifact-actions branch from d5dd161 to d156fb6 Compare December 31, 2025 13:56
@renovate renovate Bot force-pushed the renovate/major-github-artifact-actions branch from d156fb6 to 82d97fc Compare February 2, 2026 18:28
@olexs

olexs commented Feb 2, 2026

Copy link
Copy Markdown
Owner

@claude The Renovate PR build failed (workflow run: 21602405015).

Please analyze the CI failure and implement a fix if possible.

Workflow run: https://github.com/olexs/pdf-assembler/actions/runs/21602405015

@claude

claude Bot commented Feb 2, 2026

Copy link
Copy Markdown

Claude finished @olexs's task in 2m 34s —— View job


CI Failure Analysis Complete

Todo List:

  • Fetch CI workflow run details and logs
  • Read the workflow file changes
  • Analyze upload-artifact v6 breaking changes
  • Investigate root cause of test failures
  • Determine if issue is related to upload-artifact or other changes

Root Cause Identified

The CI failure is NOT related to the upload-artifact v6 upgrade. The upload-artifact action is working correctly.

The real issue: E2E tests are failing because the Electron app renderer process isn't loading properly. This is a regression from commit 00dc188 (merged in PR #779), which modified the webpack configurations to support tempy 3.x.

Evidence

  1. upload-artifact v6 works fine: The artifact upload succeeds after tests fail, and v6 only requires Node 24 (which GitHub runners have)

  2. All E2E tests timeout: Every test fails with the same error:

    TimeoutError: page.waitForSelector: Timeout 30000ms exceeded.
    waiting for locator('#input-list .list-group-item') to be visible
    
  3. App window never renders: The test logs show "Electron app closed (expected after test completion)" but never show "Window opened" messages, indicating the renderer process fails to initialize

  4. Webpack config change is suspicious: Commit 00dc188 added 'import' to the beginning of conditionNames in both webpack configs:

    - conditionNames: ['require', 'node', 'default']
    + conditionNames: ['import', 'require', 'node', 'default']

    This changes module resolution priority, potentially breaking modules that don't have proper ESM support

Recommendation

This PR (#764) is safe to merge - the upload-artifact v6 upgrade is not causing the test failures. However, master is broken due to the webpack changes from PR #779.

Next steps:

  1. Merge this PR (the artifact upgrade is fine)
  2. Open a separate issue/PR to fix the webpack configuration bug on master
  3. The fix likely involves adjusting the conditionNames order or fixing how the renderer bundle handles ESM modules

Would you like me to investigate a fix for the webpack issue, or would you prefer to handle that separately?


Workflow Run | Branch

@renovate renovate Bot changed the title chore(deps): update actions/upload-artifact action to v6 chore(deps): update actions/upload-artifact action to v7 Feb 26, 2026
@renovate renovate Bot force-pushed the renovate/major-github-artifact-actions branch from 82d97fc to 078678d Compare February 26, 2026 22:04
@olexs

olexs commented Feb 26, 2026

Copy link
Copy Markdown
Owner

@claude The Renovate PR build failed (workflow run: 22463207563).

Please analyze the CI failure and implement a fix if possible.

Workflow run: https://github.com/olexs/pdf-assembler/actions/runs/22463207563

@claude

claude Bot commented Feb 26, 2026

Copy link
Copy Markdown

Claude finished @olexs's task in 12m 48s —— View job


CI Failure Analysis & Fix

Todo List:

  • Fetch CI workflow run details and logs
  • Analyze the failure - E2E tests timeout on all tests (same as before)
  • Identify root cause
  • Implement fix: replace tempy with native Node.js temp utils
  • Revert webpack conditionNames change
  • Commit and push fix

Root Cause

All 7 E2E tests timed out waiting for #input-list .list-group-item — the app window opened but the file list never rendered.

Root cause: The conditionNames: ['import', 'require', 'node', 'default'] added in commit 00dc188 (to support tempy v3's ESM-only temp-dir dependency) causes webpack to resolve certain packages to their ESM versions at runtime. This silently breaks the Electron renderer — the bundle builds fine, but something in the ESM-resolved packages causes the renderer to fail initializing the UI.

Fix Applied

Commit 8de3491view on branch

  1. Created src/tempUtils.ts: Native Node.js replacement for tempy using os.tmpdir(), crypto.randomBytes(), path.join(), and fs.mkdirSync() — same API, no ESM dependencies
  2. Updated renderer.ts, preprocessor.ts, pdfGenerator.ts to import from ./tempUtils instead of tempy
  3. Reverted conditionNames in both webpack configs back to ['require', 'node', 'default'] — the configuration that was working before the tempy v3 upgrade

This fix should be applied to master as well (this is a regression from PR #779).


| Branch

… tests

The conditionNames: ['import', 'require', 'node', 'default'] added in
00dc188 to support tempy v3's ESM-only temp-dir dependency causes webpack
to resolve other packages to their ESM versions at runtime, silently
breaking the Electron renderer process.

Fix by replacing tempy with native Node.js implementations using os,
crypto, path, and fs built-ins in a new tempUtils.ts module. This
eliminates the need for the 'import' condition in conditionNames, and
we revert to ['require', 'node', 'default'] which was working before.

Co-authored-by: Olex S. <olexs@users.noreply.github.com>
@renovate

renovate Bot commented Feb 27, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant