fix: preserve false stylesheet booleans - #210
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Font toggles with
val="0"orval="false"now stay disabled through load/save, and explicit false XF flags survive serialization.Motivation
Closes #209
The font schema treated
b,i,strike,outline,shadow,condenseandextendas presence-only markers, ignoring theirvalattributes. SpreadsheetML'sCT_BooleanPropertyuses a boolean attribute with a default of true; the existing nested-boolean schema already models this distinction. The XF writer separately discarded false flags through truthiness checks.The regression fixture uses the report's stylesheet, with a differential font added to exercise the shared font schema. XML is preserved semantically, not byte-for-byte: true font values serialize as
val="1".Changes
Testing
pnpm test tests/styles/issue-209.test.ts— 45 failures before the fix, all 75 cases pass afterward.pnpm lint,pnpm typecheck,pnpm knip,pnpm build,pnpm size,pnpm check:attwandpnpm check:consumerpass.Breaking changes
None
Checklist
pnpm changesetand committedthe result.
marked accordingly.
comments.
PR represents real work that warrants a maintainer's review, and I am
willing to defend each line in review.