Skip to content

fix: decode numeric XML character references - #132

Merged
baseballyama merged 3 commits into
mainfrom
fix/issue-131-numeric-xml-entities
Sep 15, 2026
Merged

baseballyama merged 3 commits into
mainfrom
fix/issue-131-numeric-xml-entities

Conversation

@baseballyama

@baseballyama baseballyama commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • decode decimal and hexadecimal XML character references in text nodes and attributes
  • preserve single-pass XML entity semantics so escaped reference text is not decoded twice
  • keep CDATA sections literal (they are not entity-decoded)
  • reject references to characters XML does not allow (e.g. �) with OpenXmlSchemaError
  • cover inline strings and shared strings through loadWorkbook

Verification

  • pnpm typecheck
  • pnpm lint
  • pnpm test (328 files, 2472 tests)
  • pnpm build
  • pnpm size

Closes #131

@baseballyama
baseballyama force-pushed the fix/issue-131-numeric-xml-entities branch from 74ffbb0 to 5a9fe27 Compare September 15, 2026 20:19
@baseballyama
baseballyama merged commit 6244117 into main Sep 15, 2026
14 checks passed
@baseballyama
baseballyama deleted the fix/issue-131-numeric-xml-entities branch September 15, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: inline-string cell text with numeric XML character references (&#NNNN;) is not decoded

1 participant