fix(preview): render EMF artwork and order gradient stops - #299
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore EMF vector artwork in imported slide previews and render gradient stops in position order. A closing slide with a skyline now shows its transparent white artwork over a smooth blue background instead of an image placeholder and a horizontal color seam.
Motivation
A user reported the discrepancy between PowerPoint and the preview and supplied a reproduction file directly, so there is no separate issue. The file uses an EMF image and gradient stops serialized in the order 52%, 0%, 100%. The private presentation is not included; regression fixtures are generated in the tests.
Changes
Testing
pnpm exec vitest run test/preview-imported-artwork.test.ts test/preview-effects-fills.test.ts test/preview-node-raster.test.ts: 33 tests passed.Breaking changes
None
Checklist