Repository navigation
fix: bundle existing fonts for repeatable builds - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post-merge CI build repeatedly fails in Next's Google font loader while parsing a fetched font URL (
Cannot read properties of null (reading '1')). The production deploy build and local build pass, so retrying does not make the build path reliable.This narrow fix bundles the exact ten WOFF2 files emitted by a successful build, preserving all 31 font-face declarations, unicode ranges, requested weights, fallback metrics, three Latin preloads and CSS variables. No font family, typography, layout or cache behavior is changed. The upstream SIL Open Font License notices are included.
Local lint passes with the same eight pre-existing warnings. Next and OpenNext builds pass without the Google-font build-time fetch. Preview pixels are being compared with production before merge.
Preview: https://gitshow-font-preview.ofershap.workers.dev