You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Non-reflected property resets and a prefetch-invalidation race remain unresolved.
No open issues 🎉
2 previously missed issues
In code that hasn't changed since last review
Restore nullish resets for non-reflected properties
src/dom.ts:64
Nullish updates now leave non-reflected properties unchanged unless clearProperty explicitly handles them. For example, bindProperty(video, "muted", state) leaves video.muted true when state changes from true to null or undefined: removing the attribute affects defaultMuted, not the live playback state. A custom element's existing model property likewise retains its previous object. The same regression occurs in the JSX writer in src/jsx-runtime.ts:270–291. Restore nullish resets for non-reflected properties in both writers while keeping reflected attributes such as id absent. Add regression tests for muted and a custom-element property through both binding paths; adding only muted to the allowlist would leave the general regression unresolved.
Cancel pending navigation after prefetch entry removal
src/router.ts:977
Invalidation misses a waiting navigation after its prefetch entry has been removed but before resume runs. Register prefetched.then(() => router.invalidatePrefetch('/private')) before navigating to that pending prefetch: completion deletes the active entry and resolves the promise, then invalidation deletes the cached result but returns from abortActivePrefetch without canceling the pending navigation. resume consequently starts another loader. Global invalidation has the same gap because it only visits active entries. Cancel a matching pending navigation even when there is no active prefetch entry, and include its key when invalidating all prefetches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linked Issue
Validation
List the checks you ran and the result. If a command was skipped, explain why.
pnpm validatepnpm testpnpm typecheckpnpm buildRelease Notes