Skip to content

feat(include-qualified): support dynamic directory mappings - #16420

Merged
anmonteiro merged 2 commits into
ocaml:mainfrom
anmonteiro:anmonteiro/dynamic-directory-remappings-upstream
Sep 17, 2026
Merged

anmonteiro merged 2 commits into
ocaml:mainfrom
anmonteiro:anmonteiro/dynamic-directory-remappings-upstream

Conversation

@anmonteiro

Copy link
Copy Markdown
Collaborator

Expand variables in directory mappings and track generated mapping-file dependencies. Updates the regression tests from #16419; the child-directory limitation test will follow separately.

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
@anmonteiro
anmonteiro marked this pull request as ready for review September 17, 2026 04:04
@anmonteiro anmonteiro added the include-subdirs-qualified The `(include_subdirs qualified)` stanza — folder names become module qualifiers label Sep 17, 2026
@anmonteiro
anmonteiro merged commit 7dc34b4 into ocaml:main Sep 17, 2026
39 checks passed
@anmonteiro
anmonteiro deleted the anmonteiro/dynamic-directory-remappings-upstream branch September 17, 2026 04:57
anmonteiro added a commit that referenced this pull request Sep 17, 2026
…16421)

Document the dependency cycles when a directory mapping reads a source
or generated file in a child directory within the qualified group.
Test-only follow-up to #16420, recording the current errors as expected
output.

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
@Alizter Alizter added this to the 3.25.0 milestone Sep 17, 2026
anmonteiro added a commit that referenced this pull request Sep 18, 2026
Document qualified directory renaming and dynamic mappings from #13691
and #16420.

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

include-subdirs-qualified The `(include_subdirs qualified)` stanza — folder names become module qualifiers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants