fix(include-subdirs): reject conflicting generated modules - #16414
Merged
anmonteiro merged 4 commits intoSep 16, 2026
Merged
anmonteiro merged 4 commits into
anmonteiro merged 4 commits into
Conversation
Check parser-generator targets and generated source merges for duplicate implementations or interfaces. Preserve implementation/interface pairs and leave same-path conflicts to the rule conflict check. Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
marked this pull request as ready for review
September 15, 2026 13:26
anmonteiro
added
the
include-subdirs-qualified
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
deleted the
anmonteiro/fix-unqualified-generated-module-collisions-upstream
branch
September 16, 2026 19:10
anmonteiro
added a commit
that referenced
this pull request
Sep 17, 2026
…bdirs qualified)` (#13691) Allow literal directory mappings in qualified groups. Fixes #7605; follows #16414. Dynamic mappings are split into anmonteiro#191 and bootstrap support into anmonteiro#192. --------- Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject generated sources that conflict with other sources for the same module. Follow-up to #16410, extracted from #13691.