Conversation
Record strict package checks overlooking a dynamically read installed file, both after execution and from the workspace cache. Without strict checks, also show that the internal package-files alias omits other installed files from the dynamically discovered provider package. A static read of the same input includes them. Record the current broken behavior without changing the implementation. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Alizter
reviewed
Sep 8, 2026
| > (target output) | ||
| > (action | ||
| > (with-stdout-to output | ||
| > (dynamic-run ./foo.exe read ../install/default/share/provider/input)))) |
Collaborator
There was a problem hiding this comment.
This doesn't work even for regular run because we no longer use the install staging area for package deps.
Collaborator
There was a problem hiding this comment.
We also don't expand a package files alias any longer, so this test is a bit stale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a regression where a consumer dynamically reads a file installed by another package without declaring that package dependency. Strict package checks currently miss it both after execution and when inspecting a workspace-cached rule.
Also reproduce the missing inferred closure without
strict_package_deps: the internal@.consumer-filesalias omits the provider’s other installed file, whereas a static read of the same input includes it. This checks the package-files alias, not ordinary non-strictconsumer.installgeneration.Test only: the expectations record current broken behavior; no implementation changes are included.