Conversation
Signed-off-by: Arthur Wendling <arthur@tarides.com>
Signed-off-by: Arthur Wendling <arthur@tarides.com>
Alizter
reviewed
Sep 4, 2026
| ; dummy_impl : Input.Impl.t option | ||
| ; cache : (Input.Role.t, Candidates.t) Fiber.Cache.t | ||
| ; by_role : (Input.Role.t, Candidates.t) Table.t | ||
| ; mutable created : Candidates.t list |
Collaborator
There was a problem hiding this comment.
This can be inferred by by_role right?
Alizter
reviewed
Sep 4, 2026
| List.rev !conflicts | ||
| |> Fiber.parallel_iter ~f:(fun (impl_var, dep) -> | ||
| process_dep `No_expand impl_var dep) | ||
| (* All impl_candidates have now been added, so snapshot the cache. *) |
Collaborator
There was a problem hiding this comment.
This comment appears to be stale now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More scaffolding to prepare for the on-demand loading of opam packages: This is just breaking apart
build_problemand introducing a typeProblem.tto keep track of the state.