Conversation
Alizter
added
the
package management
Alizter
force-pushed
the
push-kzlnwxvqnmlt
branch
28 times, most recently
from
August 22, 2026 19:57
8ffe3ca to
6412fc1
Compare
Alizter
force-pushed
the
push-kzlnwxvqnmlt
branch
11 times, most recently
from
August 26, 2026 06:42
c1c277a to
1f240a2
Compare
Alizter
changed the title
Alizter
marked this pull request as ready for review
August 26, 2026 06:43
Alizter
force-pushed
the
push-kzlnwxvqnmlt
branch
3 times, most recently
from
August 26, 2026 11:48
cd73011 to
5611041
Compare
Alizter
changed the title
Alizter
changed the title
Alizter
force-pushed
the
push-kzlnwxvqnmlt
branch
from
August 26, 2026 12:48
2dfd8a1 to
b65d175
Compare
Alizter
marked this pull request as draft
August 26, 2026 12:49
Alizter
force-pushed
the
push-kzlnwxvqnmlt
branch
from
August 26, 2026 13:31
b65d175 to
07176ff
Compare
Expose the current SAT decision level and cover a conflict that backjumps over an unrelated decision. Incremental deciders can use the observed decrease to invalidate cached traversal state. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Maintain undecided variables in a linked list so the solver can choose and restore them without rescanning every variable. Freeze the variable set once decisions begin, which keeps list restoration valid across backtracking. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Keep the package decider's depth-first frontier and visited roles between monotonic SAT decisions instead of walking again from the root. Reset the cached traversal when the exposed decision level shows that conflict analysis backtracked. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Treat versioned package filenames and .files directories as an independent lock-directory layout choice. The hidden DUNE_PKG_VERSIONED_LOCK_DIR_PATHS=enabled|disabled environment variable affects only newly generated lock directories; when unset, existing portable and non-portable defaults are preserved. Readers infer the layout from package filenames and reject mixed layouts without consulting the environment. Cover both layouts with the same package solution, extra files, package digest, and build output. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Write newly generated package fields in the conditional representation regardless of how many platforms were solved. Keep legacy atom dependencies, bare build/install actions, and bare depext strings readable as unconditional values. This changes only lock-directory encoding; platform selection, solver behavior, and command diagnostics remain unchanged. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Render every successful lock operation with the platform-aware solution summary. For legacy single-platform lockdirs, treat the complete package set as common when no platform map is present. This removes the duplicate summary renderer without changing platform selection, solver behavior, failure diagnostics, or lock-directory layout. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Remove the configure-time and runtime portable_lock_dir toggle. Project lock generation now always takes the existing portable path, which was already the default; dev-tool locking retains its internal current-platform path. Migrate tests that selected the removed mode to explicit solve_for_platforms entries. Solver internals and the default requested platform set remain unchanged. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-kzlnwxvqnmlt
branch
from
August 26, 2026 22:40
07176ff to
1a181c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current stack separates three mechanical cleanups:
solve_for_platformsentries.Package path numbering is handled independently by #16218. This stack will be revised further as the semantic differences between the formats are isolated.
Checks
dune build @check @fmt