Update 5.6 support: primitive alias#642
Open
NathanReb wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
I'm opening as draft for now as it lacks the following:
In its current state though it builds on 5.6 and will correctly handle code that does not use primitive aliases so it might prove useful to people that want to give trunk a shot. I'll add full support and tests in the next few days! |
Collaborator
Author
|
I'm also hoping to see the trunk build finally go green! |
NathanReb
requested review from
ceastlund,
panglesd and
patricoferris
as code owners
NathanReb
force-pushed
the
update-5-6-support
branch
from
5d7de20 to
697a90d
Compare
Signed-off-by: Nathan Rebours <nathan.rebours@ocamlpro.com>
Signed-off-by: Nathan Rebours <nathan.rebours@ocamlpro.com>
Signed-off-by: Nathan Rebours <nathan.rebours@ocamlpro.com>
NathanReb
force-pushed
the
update-5-6-support
branch
from
697a90d to
a9aeca9
Compare
Collaborator
Author
|
hmm weird, can't see the ocaml-ci build! If it's too unstable we'll have to add more reliable github actions build I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for 5.6 primitive alias feature.
In 5.6 it is now possible to define an alias on a primitive defined elsewhere. Primitives are now represented differently in the AST so it needs to be properly migrated in between 5.6 and 5.5 and for primitive aliases, properly encoded/decoded.