Skip to content

frontend-tools: Update clock Lua script for new gs_image_file_ex - #13974

Merged
RytoEX merged 1 commit into
obsproject:masterfrom
RytoEX:fix-lua-image-file-usage
Oct 1, 2026
Merged

RytoEX merged 1 commit into
obsproject:masterfrom
RytoEX:fix-lua-image-file-usage

Conversation

@RytoEX

@RytoEX RytoEX commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Description

Follow-up to c3046ec (#11178).

That commit completely replaced the various gs_image_file* structs and functions, but this script was not updated. Use the new structs and functions to fix the script.

Motivation and Context

Want the bundled scripts to work.

How Has This Been Tested?

Tested on Windows 11. Does not require an OBS Studio rebuild. Just load the updated script in OBS Studio.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Follow-up to c3046ec.

That commit completely replaced the various gs_image_file* structs and
functions, but this script was not updated. Use the new structs and
functions to fix the script.
@RytoEX RytoEX added this to the OBS Studio 33.0 milestone Oct 1, 2026
@RytoEX RytoEX self-assigned this Oct 1, 2026
@RytoEX RytoEX added the kind/bug Categorizes issue or PR as related to a bug. label Oct 1, 2026

@Fenrirthviti Fenrirthviti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on 33.0.0 Beta5 and the error is corrected and the source works as expected.

@exeldro

exeldro commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Should the Lua script move to gs_texture_create_from_file instead? as it does not support animated gifs at the moment

@RytoEX

RytoEX commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

Should the Lua script move to gs_texture_create_from_file instead? as it does not support animated gifs at the moment

This is a valid question that I do not have an answer for. Right now the script is broken, and I just wanted it to be back in a working state.

@RytoEX
RytoEX merged commit 6377af4 into obsproject:master Oct 1, 2026
15 checks passed
@RytoEX
RytoEX deleted the fix-lua-image-file-usage branch October 1, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug.

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

5 participants