Skip to content

cmake: Make obs-core-modules header public - #13973

Merged
RytoEX merged 1 commit into
obsproject:masterfrom
FiniteSingularity:bugfix/cmake-core-modules-private
Oct 1, 2026
Merged

RytoEX merged 1 commit into
obsproject:masterfrom
FiniteSingularity:bugfix/cmake-core-modules-private

Conversation

@FiniteSingularity

Copy link
Copy Markdown
Contributor

Description

This PR makes the obs-core-modules.h header public to remain consistent with other headers in the libobs/cmake directory by adding PUBLIC to the target_sources line in obs-core-modules.cmake

Motivation and Context

This brings obs-core-modules.cmake in line with all other library files/headers handled by libobs .cmake files.

How Has This Been Tested?

The cmake build process has been run successfully with these changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

This PR makes the obs-core-modules.h header public to remain consistent
with other headers in the libobs/cmake directory.
@RytoEX RytoEX added this to the OBS Studio 33.0 milestone Oct 1, 2026
@RytoEX
RytoEX requested review from PatTheMav and tytan652 October 1, 2026 17:36
@RytoEX RytoEX self-assigned this Oct 1, 2026
@RytoEX RytoEX added the kind/bug Categorizes issue or PR as related to a bug. label Oct 1, 2026

@tytan652 tytan652 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RytoEX
RytoEX merged commit d20b469 into obsproject:master Oct 1, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug.

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

5 participants