Skip to content

frontend, shared: Remove code for Qt versions older than 6.10 - #13969

Open
RytoEX wants to merge 5 commits into
obsproject:masterfrom
RytoEX:remove-qt64
Open

RytoEX wants to merge 5 commits into
obsproject:masterfrom
RytoEX:remove-qt64

Conversation

@RytoEX

@RytoEX RytoEX commented Oct 1, 2026

Copy link
Copy Markdown
Member

Description

Remove code for Qt versions older than 6.10

Motivation and Context

Qt 6.10 is the minimum supported Qt version now.

Note that this does remove code that is modified in #13622. If it's preferable to simply leave that code untouched, then I'll just do that.

See:

How Has This Been Tested?

Compiled and ran locally on Windows 11.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Qt 6.10 is the minimum supported Qt version now.
Qt 6.10 is the minimum supported Qt version now.
@RytoEX RytoEX self-assigned this Oct 1, 2026
@RytoEX RytoEX added the kind/cleanup Non-breaking change which makes code smaller or more readable label Oct 1, 2026
clang-format apparently requires this block to be reformatted.
@tytan652

tytan652 commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

It's missing removal in-cmake code, e.g.

if(Qt6_VERSION AND Qt6_VERSION VERSION_LESS "6.9.0")
target_link_libraries(obs-studio PRIVATE Qt::GuiPrivate)
endif()

@RytoEX

RytoEX commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

It's missing removal in-cmake code, e.g.

if(Qt6_VERSION AND Qt6_VERSION VERSION_LESS "6.9.0")
target_link_libraries(obs-studio PRIVATE Qt::GuiPrivate)
endif()

Pushed a squash commit addressing this.

@tytan652

tytan652 commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

os-freebsd.cmake had one too…

@RytoEX

RytoEX commented Oct 2, 2026

Copy link
Copy Markdown
Member Author

os-freebsd.cmake had one too…

Found and removed.

@tytan652 tytan652 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warchamp7 Warchamp7 added the release-note/developer Groups pull request under the "Developer Notes" section in the associated patch notes label Oct 2, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Non-breaking change which makes code smaller or more readable release-note/developer Groups pull request under the "Developer Notes" section in the associated patch notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants