Skip to content

Remove support for FFmpeg 6.x and 7.0 - #13964

Open
RytoEX wants to merge 3 commits into
obsproject:masterfrom
RytoEX:remove-ffmpeg61
Open

RytoEX wants to merge 3 commits into
obsproject:masterfrom
RytoEX:remove-ffmpeg61

Conversation

@RytoEX

@RytoEX RytoEX commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Description

Remove code supporting FFmpeg 6.x and 7.x (FFmpeg < 8.0).

Specifically, remove compatibility code for FFmpeg 6.1 that targets:

  • libavcodec < 62
  • libavformat < 62

Motivation and Context

Removing FFmpeg<8.0 code. See:

How Has This Been Tested?

It hasn't been tested yet.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX added kind/cleanup Non-breaking change which makes code smaller or more readable Seeking Testers Build artifacts on CI labels Sep 29, 2026

@PatTheMav PatTheMav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this primarily require assistance to be tested on Linux?

@tytan652 tytan652 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are breaking compat with FFmpeg 7.0.

@tytan652 tytan652 Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes support for FFmpeg 7.0 (61, 3, 100 for 7.0.3).

@tytan652 tytan652 Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes support for FFmpeg 7.0 (61, 3, 100 for 7.0.3).

@tytan652

tytan652 commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Specifically, remove compatibility code for FFmpeg 6.1 that targets:

* libavcodec < 62

* libavformat < 62

The bullet list does not align with the first statement, the version 61 of both is under FFmpeg 7.x.

Edit: 60 is to be excluded so "< 61" if only FFmpeg 6.x is removed

@RytoEX

RytoEX commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

The "Remove code supporting FFmpeg 6.1" is a bit of a misnomer. The actual goal is "remove support for FFmpeg versions older than what Ubuntu 26.04 ships with", and that version is FFmpeg 8.0.

@tytan652

tytan652 commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Then it needs to be rename to something like "Remove support for FFmpeg 6.x and 7.0", the actual name is mismatching the scope of the change itself.

@RytoEX RytoEX changed the title Remove code supporting FFmpeg 6.1 Remove code supporting FFmpeg 6.x and 7.x Sep 30, 2026
@RytoEX

RytoEX commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

Then it needs to be rename to something like "Remove support for FFmpeg 6.x and 7.0", the actual name is mismatching the scope of the change itself.

Updated PR name. Will update commit messages later.

@RytoEX

RytoEX commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

Updated commit messages. No code changes pushed.

@RytoEX RytoEX changed the title Remove code supporting FFmpeg 6.x and 7.x Remove support for FFmpeg 6.x and 7.0 Sep 30, 2026
Remove compatibility code for FFmpeg<8.0 that targets:
* libavcodec < 62
* libavformat < 62
Remove compatibility code for FFmpeg<8.0 that targets:
* libavcodec < 62
@RytoEX

RytoEX commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

Would this primarily require assistance to be tested on Linux?

That it compiles on Ubuntu is probably a sufficient compile test. Runtime testing on any OS should suffice.

@tytan652

tytan652 commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

I think there is some find_package(FFmpeg in Cmake that do have a version as argument, they should be bumped.

@RytoEX

RytoEX commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

I think there is some find_package(FFmpeg in Cmake that do have a version as argument, they should be bumped.

Added a separate commit changing the only find_package(FFmpeg that specified a version number. Semantically, the commits should probably be reversed.

@RytoEX
RytoEX requested review from PatTheMav and tytan652 October 1, 2026 18:48

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Non-breaking change which makes code smaller or more readable Seeking Testers Build artifacts on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants