Conversation
PatTheMav
left a comment
There was a problem hiding this comment.
Would this primarily require assistance to be tested on Linux?
tytan652
left a comment
There was a problem hiding this comment.
Some changes are breaking compat with FFmpeg 7.0.
There was a problem hiding this comment.
This removes support for FFmpeg 7.0 (61, 3, 100 for 7.0.3).
There was a problem hiding this comment.
This removes support for FFmpeg 7.0 (61, 3, 100 for 7.0.3).
The bullet list does not align with the first statement, the version 61 of both is under FFmpeg 7.x. Edit: 60 is to be excluded so "< 61" if only FFmpeg 6.x is removed |
|
The "Remove code supporting FFmpeg 6.1" is a bit of a misnomer. The actual goal is "remove support for FFmpeg versions older than what Ubuntu 26.04 ships with", and that version is FFmpeg 8.0. |
|
Then it needs to be rename to something like "Remove support for FFmpeg 6.x and 7.0", the actual name is mismatching the scope of the change itself. |
Updated PR name. Will update commit messages later. |
b2c0c6e to
a0da53f
Compare
|
Updated commit messages. No code changes pushed. |
Remove compatibility code for FFmpeg<8.0 that targets: * libavcodec < 62 * libavformat < 62
Remove compatibility code for FFmpeg<8.0 that targets: * libavcodec < 62
a0da53f to
69d974c
Compare
That it compiles on Ubuntu is probably a sufficient compile test. Runtime testing on any OS should suffice. |
|
I think there is some |
Added a separate commit changing the only |
Description
Remove code supporting FFmpeg 6.x and 7.x (FFmpeg < 8.0).
Specifically, remove compatibility code for FFmpeg 6.1 that targets:
Motivation and Context
Removing FFmpeg<8.0 code. See:
How Has This Been Tested?
It hasn't been tested yet.
Types of changes
Checklist: