frontend: Limit missing encoder check by output mode - #13950
Merged
RytoEX merged 1 commit intoSep 30, 2026
Merged
Conversation
Warchamp7
force-pushed
the
check-missing-encoder-active-only
branch
from
September 28, 2026 21:52
5e08237 to
57ba3da
Compare
Member
|
Will this alert if you changed from simple with a good codec to advanced with a bad codec and hit ok/save? Just thinking of other routes that the error might be relevant for. |
RytoEX
added
the
release-note/fix
Member
Author
If you swap from Simple to Advanced, the settings dialog will block you from saving changes due to encoders not being properly configured, until you change them. If you swap from Advanced to Simple, the values get soft reset. |
|
SHIP IT 
|
PatTheMav
approved these changes
Sep 29, 2026
RytoEX
requested changes
Sep 29, 2026
RytoEX
left a comment
RytoEX
left a comment
Member
There was a problem hiding this comment.
Could you explain why in the commit message?
Adjust the check for missing encoders to only check encoders for the currently set Output Mode (Simple or Advanced). Avoids a confusing warning when OBS is set to Simple output mode but the encoder that was previously configured for Advanced has gone missing.
Warchamp7
force-pushed
the
check-missing-encoder-active-only
branch
from
September 30, 2026 17:50
57ba3da to
7790069
Compare
Member
Author
Updated. |
RytoEX
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The check added in #11340 checks the values of both the Simple and Advanced Output modes since those unfortunately are saved as separate sets of data.
However this means that if OBS is set to Simple output mode, but Advanced was configured at some point with an encoder that has since gone missing, the warning will pop up despite seemingly nothing visible being wrong in the settings window.
Fixes #13944
Motivation and Context
Fix confusing errors.
How Has This Been Tested?
Manually edited
basic.inifor my profile with bad values for SimpleOutput and AdvOut encoder fields.Bad values under SimpleOutput were only flagged when
[Output]->Modewas set toSimple.Bad values under AdvOut were only flagged when
[Output]->Modewas set toAdvanced.Types of changes
Checklist: