feat: add forwardTipsImmediately config flag to KeepWhatsRaised#87
Open
Suvadra-Barua wants to merge 8 commits intomainfrom
Open
feat: add forwardTipsImmediately config flag to KeepWhatsRaised#87Suvadra-Barua wants to merge 8 commits intomainfrom
Suvadra-Barua wants to merge 8 commits intomainfrom
Conversation
This reverts commit b2c09ec.
Cover the three key behaviors when Config.forwardTipsImmediately is true: - claimTip() reverts with KeepWhatsRaisedTipsAlreadyForwarded - Permit2 pledge forwards tip to platform admin at pledge time - Admin setFeeAndPledge splits pledge vs tip accounting correctly Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
test(foundry): add forwardTipsImmediately unit tests
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
adnanhq
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new forwardTipsImmediately boolean flag to the treasury Config struct. When enabled (currently set for Colombian creator campaigns), tips are forwarded directly to the platform admin at pledge time instead of accumulating in the contract for a later claimTip() call.
Changes
src/treasuries/KeepWhatsRaised.sol
test/foundry/unit/KeepWhatsRaised.t.sol
Added 14 new unit tests covering: