fix(bld): workaround for version mismatch in nwjs.app - #1628

Merged

ayushmanchhabra merged 3 commits into

mainfrom

fix/macos-helper-rename

Jul 25, 2026

ayushmanchhabra commented Jul 25, 2026

Collaborator

Fixes: #1624


          fix(bld): use the symlinked Current dir instead of actual version

7c92654

github-actions Bot commented Jul 25, 2026 •

edited

Loading

Contributor

Coverage Report for Vitest Coverage (ubuntu-24.04-arm)

Status	Category	Percentage	Covered / Total
🔵	Lines	21.07%	110 / 522
🔵	Statements	21.03%	110 / 523
🔵	Functions	29.72%	11 / 37
🔵	Branches	24.54%	134 / 546

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
src/bld/osx.js	0%	0%	0%	0%	22-220

Generated in workflow #1075 for commit 9a93d1f by the Vitest Coverage Report Action

github-actions Bot commented Jul 25, 2026 •

edited

Loading

Contributor

Coverage Report for Vitest Coverage (ubuntu-24.04)

Status	Category	Percentage	Covered / Total
🔵	Lines	21.07%	110 / 522
🔵	Statements	21.03%	110 / 523
🔵	Functions	29.72%	11 / 37
🔵	Branches	24.54%	134 / 546

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
src/bld/osx.js	0%	0%	0%	0%	22-220

Generated in workflow #1075 for commit 9a93d1f by the Vitest Coverage Report Action

github-actions Bot commented Jul 25, 2026 •

edited

Loading

Contributor

Coverage Report for Vitest Coverage (windows-2025)

Status	Category	Percentage	Covered / Total
🔵	Lines	19.92%	104 / 522
🔵	Statements	19.88%	104 / 523
🔵	Functions	29.72%	11 / 37
🔵	Branches	22.34%	122 / 546

File Coverage

No changed files found.

Generated in workflow #1075 for commit 9a93d1f by the Vitest Coverage Report Action

github-actions Bot commented Jul 25, 2026 •

edited

Loading

Contributor

Coverage Report for Vitest Coverage (windows-11-arm)

Status	Category	Percentage	Covered / Total
🔵	Lines	19.92%	104 / 522
🔵	Statements	19.88%	104 / 523
🔵	Functions	29.72%	11 / 37
🔵	Branches	22.34%	122 / 546

File Coverage

No changed files found.

Generated in workflow #1075 for commit 9a93d1f by the Vitest Coverage Report Action


          chore(ci): change assert from chromiumVersion to Current dir

e0c4460

github-actions Bot commented Jul 25, 2026 •

edited

Loading

Contributor

Coverage Report for Vitest Coverage (macos-26)

Status	Category	Percentage	Covered / Total
🔵	Lines	29.31%	153 / 522
🔵	Statements	29.25%	153 / 523
🔵	Functions	43.24%	16 / 37
🔵	Branches	21.61%	118 / 546

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
src/bld/osx.js	89.28%	58.33%	100%	89.28%	47-49, 58, 99-102, 134-137, 187, 220

Generated in workflow #1075 for commit 9a93d1f by the Vitest Coverage Report Action

github-actions Bot commented Jul 25, 2026 •

edited

Loading

Contributor

Coverage Report for Vitest Coverage (macos-26-intel)

Status	Category	Percentage	Covered / Total
🔵	Lines	29.31%	153 / 522
🔵	Statements	29.25%	153 / 523
🔵	Functions	43.24%	16 / 37
🔵	Branches	21.61%	118 / 546

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
src/bld/osx.js	89.28%	58.33%	100%	89.28%	47-49, 58, 99-102, 134-137, 187, 220

Generated in workflow #1075 for commit 9a93d1f by the Vitest Coverage Report Action


          chore: add TODOs in relevant places

9a93d1f

ayushmanchhabra merged commit fdddcf0 into main

9 checks passed

ayushmanchhabra deleted the fix/macos-helper-rename branch

July 25, 2026 17:13

github-actions Bot mentioned this pull request

chore(main): release 4.18.0 #1626

Merged

ayushmanchhabra pushed a commit that referenced this pull request


          chore(main): release 4.18.0 (#1626)

5f0d0c6

🤖 I have created a release *beep* *boop*
---


##
[4.18.0](v4.17.13...v4.18.0)
(2026-07-25)


### Features

* **bld:** add option to ignore files/folder during file globbing
([#1615](#1615))
([6a3eb87](6a3eb87))


### Bug Fixes

* **bld:** workaround for version mismatch in nwjs.app
([#1628](#1628))
([fdddcf0](fdddcf0)),
closes [#1624](#1624)


### Chores

* **ci:** run tests on {Linux, Mac, Windows} x {Intel, ARM}
([#1625](#1625))
([846ca3b](846ca3b))
* **deps:** bump the gha group across 1 directory with 3 updates
([#1622](#1622))
([9d4ed4f](9d4ed4f))
* **deps:** bump the npm group across 1 directory with 7 updates
([#1627](#1627))
([9a9cdd5](9a9cdd5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

ayushmanchhabra mentioned this pull request

Chromium version mismatch in https://nwjs.io/versions.json and inside nwjs.app nwjs/nw.js#8371

Open

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet