Skip to content

nwjs: show an optional splash window while the main window loads - #169

Closed
woahwhattheheck wants to merge 1 commit into
nwjs:mainfrom
woahwhattheheck:feat/issuehunt151-window-splash-20261008
Closed

woahwhattheheck wants to merge 1 commit into
nwjs:mainfrom
woahwhattheheck:feat/issuehunt151-window-splash-20261008

Conversation

@woahwhattheheck

@woahwhattheheck woahwhattheheck commented Oct 8, 2026 •

Copy link
Copy Markdown

Companion implementation for nwjs/nw.js#8390, which supplies the nw.js manifest, documentation and sanity tests. Implements the window.splash manifest field requested in nwjs/nw.js#151.

window.splash is the path/URL of a page or image, or {url, width, height, min_duration, transparent}. When it is set, nwjs/newwin.js (NW2) and nwjs/default.js (NW1):

  • open a frameless, centered, always-on-top splash window that is not in the taskbar (an image without a size is sized to the image; otherwise 400x300)
  • create the main window hidden
  • once the main window has loaded (the same signal as the loaded event) and min_duration ms have passed, show the main window (unless show is false) and close the splash
  • close the splash if the main window is closed or fails to be created; if the splash fails, the main window is shown on load as usual

Without window.splash both scripts make exactly the same window calls as before.

Scope and validation: This splash starts after the application package has been read and covers main-window loading. It does not yet cover archive extraction, which the reporter also requested in #151. The two bootstrap scripts passed 18 mocked VM checks and syntax checks in the original engineering run. The three-line C++ change was not compiled, and the two sanity tests were not run in an NW.js runtime. No full build or broad suite is claimed.

This is the companion contribution to the funded IssueHunt #151 bounty; the reward claim will be registered with the linked nw.js PR under @woahwhattheheck.

…p ci]

Original-source-commit: eee854fff34b28fb0043ca48aea067e89daeb55d
Original-author: woahwhattheheck <293286387+woahwhattheheck@users.noreply.github.com>

Exact retained patch; no tests or build rerun for publication.
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

Thanks for your contribution! Unfortunately, we don't use GitHub pull requests to manage code contributions to this repository. Instead, please see README.md which provides full instructions on how to get involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant