Repository navigation
nwjs: show an optional splash window while the main window loads - #169
Closed
woahwhattheheck wants to merge 1 commit into
Closed
woahwhattheheck wants to merge 1 commit into
woahwhattheheck wants to merge 1 commit into
Conversation
…p ci] Original-source-commit: eee854fff34b28fb0043ca48aea067e89daeb55d Original-author: woahwhattheheck <293286387+woahwhattheheck@users.noreply.github.com> Exact retained patch; no tests or build rerun for publication.
|
Thanks for your contribution! Unfortunately, we don't use GitHub pull requests to manage code contributions to this repository. Instead, please see README.md which provides full instructions on how to get involved. |
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion implementation for nwjs/nw.js#8390, which supplies the nw.js manifest, documentation and sanity tests. Implements the
window.splashmanifest field requested in nwjs/nw.js#151.window.splashis the path/URL of a page or image, or{url, width, height, min_duration, transparent}. When it is set,nwjs/newwin.js(NW2) andnwjs/default.js(NW1):loadedevent) andmin_durationms have passed, show the main window (unlessshowis false) and close the splashWithout
window.splashboth scripts make exactly the same window calls as before.Scope and validation: This splash starts after the application package has been read and covers main-window loading. It does not yet cover archive extraction, which the reporter also requested in #151. The two bootstrap scripts passed 18 mocked VM checks and syntax checks in the original engineering run. The three-line C++ change was not compiled, and the two sanity tests were not run in an NW.js runtime. No full build or broad suite is claimed.
This is the companion contribution to the funded IssueHunt #151 bounty; the reward claim will be registered with the linked nw.js PR under @woahwhattheheck.