Smoke test all locales - #20742
Open
seanbudd wants to merge 13 commits into
Open
Conversation
seanbudd
force-pushed
the
smokeTestsLocales
branch
from
August 26, 2026 03:23
ead485d to
9bd1100
Compare
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
This reverts commit 05e2ff0.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Robot Framework smoke test suite to start NVDA once per locale found under source/locale, failing CI if any locale prevents NVDA from starting (intended as a last-line safeguard against broken localizations causing startup failures).
Changes:
- Adds a new
l10nsystem test suite that iterates all locale codes and validates NVDA startup per locale. - Adds a small Python helper library to discover locale codes from
source/locale. - Extends
NvdaLib.start_NVDAto allow overriding NVDA’s startup language via the--langcommand-line option, and wires the new suite into the CI system test matrix.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/system/robot/l10nTests.robot | New Robot Framework suite that loops through locale codes and smoke-tests NVDA startup per locale. |
| tests/system/robot/l10nTests.py | Helper to enumerate locale codes from source/locale for the new suite. |
| tests/system/libraries/NvdaLib.py | Adds optional language parameter to NVDA startup to support per-locale launches. |
| .github/workflows/testAndPublish.yml | Adds l10n to the system test matrix so the new suite runs in CI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
seanbudd
marked this pull request as draft
August 26, 2026 23:02
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
seanbudd
marked this pull request as ready for review
August 26, 2026 23:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
2026.2rc1 would not start for Hungarian users due to bad localisations.
While we should have better validation for translation materials to prevent this, having a final safety smoke test against all locales would be useful.
Description of user facing changes:
None
Description of developer facing changes:
None
Description of development approach:
Scan
source/localeand try to start NVDA with each locale. If NVDA fails to start for any locale, fail the testTesting strategy:
Known issues with pull request:
Code Review Checklist: