Skip to content

Smoke test all locales - #20742

Open
seanbudd wants to merge 13 commits into
masterfrom
smokeTestsLocales
Open

Smoke test all locales#20742
seanbudd wants to merge 13 commits into
masterfrom
smokeTestsLocales

Conversation

@seanbudd

@seanbudd seanbudd commented Aug 26, 2026

Copy link
Copy Markdown
Member

Link to issue number:

None

Summary of the issue:

2026.2rc1 would not start for Hungarian users due to bad localisations.
While we should have better validation for translation materials to prevent this, having a final safety smoke test against all locales would be useful.

Description of user facing changes:

None

Description of developer facing changes:

None

Description of development approach:

Scan source/locale and try to start NVDA with each locale. If NVDA fails to start for any locale, fail the test

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Comment thread tests/system/robot/l10nTests.py Fixed
@seanbudd
seanbudd marked this pull request as ready for review August 26, 2026 07:59
@seanbudd
seanbudd requested a review from a team as a code owner August 26, 2026 07:59
@seanbudd
seanbudd requested review from SaschaCowley and a lite review from Copilot August 26, 2026 07:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Robot Framework smoke test suite to start NVDA once per locale found under source/locale, failing CI if any locale prevents NVDA from starting (intended as a last-line safeguard against broken localizations causing startup failures).

Changes:

  • Adds a new l10n system test suite that iterates all locale codes and validates NVDA startup per locale.
  • Adds a small Python helper library to discover locale codes from source/locale.
  • Extends NvdaLib.start_NVDA to allow overriding NVDA’s startup language via the --lang command-line option, and wires the new suite into the CI system test matrix.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
tests/system/robot/l10nTests.robot New Robot Framework suite that loops through locale codes and smoke-tests NVDA startup per locale.
tests/system/robot/l10nTests.py Helper to enumerate locale codes from source/locale for the new suite.
tests/system/libraries/NvdaLib.py Adds optional language parameter to NVDA startup to support per-locale launches.
.github/workflows/testAndPublish.yml Adds l10n to the system test matrix so the new suite runs in CI.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/system/robot/l10nTests.py Outdated
Comment thread tests/system/libraries/NvdaLib.py
Comment thread tests/system/robot/l10nTests.robot
@seanbudd
seanbudd marked this pull request as draft August 26, 2026 23:02
seanbudd and others added 2 commits August 27, 2026 09:27
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@seanbudd
seanbudd marked this pull request as ready for review August 26, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants