Repository navigation
Conversation
Disable Xdebug by default in the PHP image, remove deprecated Rector skips and use stubs instead of mocks without expectations. 🤖 Generated with Claude Code
🤖 Generated with Claude Code
🤖 Generated with Claude Code
Update all actions to their latest majors, pass the Codecov token and move the prettier token to the github_token input. Run PHP 8.5 and Node 24 locally to match the newest CI versions. 🤖 Generated with Claude Code
The action publishes no floating v4 tag. 🤖 Generated with Claude Code
Rector cached into the temporary directory of the removed container. 🤖 Generated with Claude Code
This reverts commit 5b54018.
prettier_action v4 ignores prettier_version and formats with prettier 3, which conflicts with the local prettier 2.8.8. 🤖 Generated with Claude Code
It scanned the PHP files of the new Rector cache in rector-tmp-dir. 🤖 Generated with Claude Code
Tests connect to Redis through the phpredis extension and set the Scout driver to null. 🤖 Generated with Claude Code
🤖 Generated with Claude Code
🤖 Generated with Claude Code
🤖 Generated with Claude Code
GitHub sets head_ref only for pull_request events, so it was always empty. 🤖 Generated with Claude Code
Tests read LIGHTHOUSE_TEST_DB_USERNAME, not LIGHTHOUSE_TEST_DB_USER. 🤖 Generated with Claude Code
Laravel connects to MySQL through pdo_mysql. 🤖 Generated with Claude Code
🤖 Generated with Claude Code
🤖 Generated with Claude Code
🤖 Generated with Claude Code
🤖 Generated with Claude Code
🤖 Generated with Claude Code
🤖 Generated with Claude Code
🤖 Generated with Claude Code
🤖 Generated with Claude Code
🤖 Generated with Claude Code
🤖 Generated with Claude Code
With older Scout versions, Larastan fails without the Algolia client. 🤖 Generated with Claude Code
Turn reportUnmatchedIgnoredErrors off again: inline ignores have no per-comment opt-out, and 55 of them are needed only on some versions. 🤖 Generated with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
maketook 68s and printed Rector warnings and 22 PHPUnit notices.Now it takes 35s and runs clean.
GitHub Actions and the local PHP and Node images are on their latest majors.
Xdebug is off by default in the PHP image, which halves test time
Xdebug ran in
developmode on every run.Tests dropped from 50s to 29s with
xdebug.mode=off.CONTRIBUTING.mdshows how to enable it withXDEBUG_MODE=debug, and replaces the Xdebug 2 settingXDEBUG_REMOTE_HOSTwithXDEBUG_CONFIG="client_host=<ip>".CI runs prettier from docs/package.json, like make prettier
creyD/prettier_action@v4ignoresprettier_versionand formats with prettier 3, which conflicts with the local prettier 2.8.8.The job now runs
yarn run prettifyindocsand commits throughgit-auto-commit-action.Rector and prettier keep their caches between runs
Rector cached into the temporary directory of the removed container, so it now writes to
rector-tmp-dir.Prettier runs with
--cache.Rector dropped from 8s to 1s, prettier from 4s to 1s.
Actions with changed inputs got matching config
codecov/codecov-action@v7gets theCODECOV_TOKENsecret, which newer versions require.The other actions keep their inputs.
Local images run PHP 8.5 and Node 24, matching the newest CI versions
On PHP 8.5, PHPStan types
chr()asint<0, 255>, soRoleFactorykeeps a targeted@phpstan-ignore argument.type.Tests use stubs where they configure no expectations
PHPUnit 12 flags mocks without expectations.
createStubreplacescreateMockin the subscription tests, andSubscriptionTestregisters a plain resolver instead ofmockResolverExpects($this->any()).Dead tooling config is gone
predis/predis: tests use the phpredis extension.mysqliextension in CI and the PHP image: Laravel connects throughpdo_mysql.LIGHTHOUSE_TEST_DB_USERin CI: tests readLIGHTHOUSE_TEST_DB_USERNAME.osmatrix in the test job, which the job name does not include.ref: ${{ github.head_ref }}in workflows withoutpull_requestevents, where it is always empty.composer install --no-suggest, a no-op since Composer 2.phpstan.neonpatterns and 25 inline@phpstan-ignorecomments that match nothing in any CI job.reportUnmatchedIgnoredErrorsstays off, because 55 inline ignores are needed only on some versions and have no per-comment opt-out.excludePathsentry, a commented-out PHPStan option, thebuildentry in.gitignoreand the permission for the nonexistentmake up.Rector skips 5 fewer rules
Rector reported them as deprecated or never registered.
Breaking changes
None.
Changelog
None.
🤖 Generated with Claude Code