Repository navigation
Conversation
Copilot stopped reviewing on behalf of
spawnia due to an error
October 25, 2026 12:22
Collaborator
|
🤖 @jaulz #2807 fixes the same bug one level lower: It also covers paginated |
1 of 2 tasks
| protected function storeLoadedResult(Model $parent, mixed $result): void | ||
| { | ||
| // Same attribute name as CountModelsLoader::extractCount() reads | ||
| $parent->setAttribute(Str::snake("{$this->relation()}_count"), $result); |
Contributor
Author
|
@spawnia that would help as well. Thanks for taking care of it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
RelationBatchLoaderkeeps one parent per model key: when the same model is reached more than once under a field (e.g. the samePostunder twoTags), each later instance overwrites the previous one in$parents, so only the last instance receives the eager loaded relation.@withand@withCountdiscard the batch loader's result and run the resolver on their own parent, assuming the relation (or count attribute) is now present on it. That only holds for the last instance; every other instance of the same model lazy loads the relation in the resolver, one query per duplicate. WithModel::preventLazyLoading()enabled, it throws instead.This adds a
hydrate()hook toWithRelationDirectivethat receives the batch loader's result before the resolver runs:@withsets the relation on the parent (the first level of a dotted relation, which holds the nested ones)@withCountsets the{relation}_countattribute on the parentBreaking changes
None. Only subclasses of
WithRelationDirectivethat already define ahydrate()method with a different signature would conflict.Changelog
Fixed
@withand@withCountresults onto every instance of a model reached multiple times in one query