Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port of PR 89 from 11.0.
The review counter in the systray was refreshed on every bus notification, whatever its channel, and also when the longpolling came back empty, which the main tab gets every 50 seconds. The refresh was a regular RPC, so whenever the workers were busy the web client blocked the screen while it waited for a free one.
With PR 89 the counter is refreshed only when a batch carries a notification of its own channel, and the commits on top do it once per batch and with a shadow RPC. The second commit of PR 89 comes without its Python part, which 14.0 already has.
Cancelling, resetting to draft or deleting a document with reviews did not notify the counter, which went unnoticed while any notification refreshed it. The mixin now notifies when it removes reviews.
The QUnit tests run the menu on the real bus service with the longpolling route mocked.