This repository was archived by the owner on Sep 19, 2026. It is now read-only.
Conversation
Mic92
commented
Jul 29, 2026
Mic92
commented
Member
- restrict secret access to trusted peers
- update-secrets: don't follow symlinks when writing secrets
- watcher: fix fd leak and handle inotify overflow
The unit/secret name comes from the client-chosen socket address, so anyone able to connect could read any service's secrets. Check SO_PEERCRED (root or own uid) and ship the socket unit with mode 0600.
The tool runs as root in a directory owned by the service user; a predictable temp file name allowed redirecting the write via a symlink. Create the temp file with O_EXCL and chown it via the fd.
connFd() dup'ed the fd and never closed it; the map cleanup used defer in an endless loop; an inotify queue overflow killed the daemon instead of re-scanning the secrets directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.