Repository navigation
fix: avoid stack overflow on table separator lines with many columns #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 changes: 99 additions & 0 deletions
99
...tables/src/test/java/com/vladsch/flexmark/ext/tables/TableSeparatorStackOverflowTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| package com.vladsch.flexmark.ext.tables; | ||
|
|
||
| import com.vladsch.flexmark.html.HtmlRenderer; | ||
| import com.vladsch.flexmark.parser.Parser; | ||
| import com.vladsch.flexmark.util.data.DataHolder; | ||
| import com.vladsch.flexmark.util.data.MutableDataSet; | ||
| import org.junit.Test; | ||
|
|
||
| import java.util.Arrays; | ||
| import java.util.concurrent.atomic.AtomicReference; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertNull; | ||
| import static org.junit.Assert.assertTrue; | ||
|
|
||
| public class TableSeparatorStackOverflowTest { | ||
| // The default thread stack size differs per platform, so the tests pin one to stay deterministic. | ||
| private static final long STACK_SIZE_BYTES = 512 * 1024; | ||
| private static final int COLUMNS = 5000; | ||
|
|
||
| private static String renderOnSmallStack(String markdown, int minSeparatorDashes) throws InterruptedException { | ||
| DataHolder options = new MutableDataSet() | ||
| .set(TablesExtension.MIN_SEPARATOR_DASHES, minSeparatorDashes) | ||
| .set(Parser.EXTENSIONS, Arrays.asList(TablesExtension.create())) | ||
| .toImmutable(); | ||
| Parser parser = Parser.builder(options).build(); | ||
| HtmlRenderer renderer = HtmlRenderer.builder(options).build(); | ||
|
|
||
| AtomicReference<String> html = new AtomicReference<>(); | ||
| AtomicReference<Throwable> failure = new AtomicReference<>(); | ||
| Thread thread = new Thread(null, () -> { | ||
| try { | ||
| html.set(renderer.render(parser.parse(markdown))); | ||
| } catch (Throwable t) { | ||
| failure.set(t); | ||
| } | ||
| }, "table-separator-stack-overflow-test", STACK_SIZE_BYTES); | ||
| thread.start(); | ||
| thread.join(); | ||
|
|
||
| assertNull("rendering must not fail: " + failure.get(), failure.get()); | ||
| return html.get(); | ||
| } | ||
|
|
||
| private static String wideTable(String separatorCell) { | ||
| StringBuilder header = new StringBuilder("|"); | ||
| StringBuilder separator = new StringBuilder("|"); | ||
| StringBuilder body = new StringBuilder("|"); | ||
| for (int i = 0; i < COLUMNS; i++) { | ||
| header.append("h|"); | ||
| separator.append(separatorCell).append('|'); | ||
| body.append("v|"); | ||
| } | ||
| return header + "\n" + separator + "\n" + body + "\n"; | ||
| } | ||
|
|
||
| private static int count(String text, String needle) { | ||
| int count = 0; | ||
| for (int i = text.indexOf(needle); i >= 0; i = text.indexOf(needle, i + needle.length())) count++; | ||
| return count; | ||
| } | ||
|
|
||
| @Test | ||
| public void wideTable_plainSeparator() throws InterruptedException { | ||
| String html = renderOnSmallStack(wideTable("---"), 3); | ||
| assertEquals(COLUMNS, count(html, "<th>")); | ||
| assertEquals(COLUMNS, count(html, "<td>")); | ||
| } | ||
|
|
||
| @Test | ||
| public void wideTable_leftAlignedSeparator() throws InterruptedException { | ||
| String html = renderOnSmallStack(wideTable(":-"), 1); | ||
| assertEquals(COLUMNS, count(html, "<th align=\"left\">")); | ||
| } | ||
|
|
||
| @Test | ||
| public void wideTable_rightAlignedSeparator() throws InterruptedException { | ||
| String html = renderOnSmallStack(wideTable("-:"), 1); | ||
| assertEquals(COLUMNS, count(html, "<th align=\"right\">")); | ||
| } | ||
|
|
||
| @Test | ||
| public void wideTable_centerAlignedSeparator() throws InterruptedException { | ||
| String html = renderOnSmallStack(wideTable(" :-: "), 1); | ||
| assertEquals(COLUMNS, count(html, "<th align=\"center\">")); | ||
| } | ||
|
|
||
| @Test | ||
| public void mixedAlignment_isKept() throws InterruptedException { | ||
| String html = renderOnSmallStack("" + | ||
| "a|b|c|d\n" + | ||
| ":--|:-:|--:|---\n" + | ||
| "1|2|3|4\n", 3); | ||
| assertTrue(html, html.contains("<th align=\"left\">a</th>")); | ||
| assertTrue(html, html.contains("<th align=\"center\">b</th>")); | ||
| assertTrue(html, html.contains("<th align=\"right\">c</th>")); | ||
| assertTrue(html, html.contains("<th>d</th>")); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.