Repository navigation
fix(deps): upgrade backlog-js to 1.1.0 and use standalone functions - #181
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…hods backlog-js 1.0.0 exports every API method as a function that takes a client as its first argument. Commands now call those functions with the client from getClient, which is built with createClient. Tests forward the functions to the mock client's methods through @repo/test-utils/mock-backlog-js, so existing stubs and assertions stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1.1.0 encodes IDs and keys before putting them in API paths, so a value containing `/`, `?`, `#` or `..` can no longer reach another endpoint. bee passes raw values and never encodes them itself, so nothing is double-encoded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Eotel
added a commit
to Eotel/bee
that referenced
this pull request
Nov 19, 2026
Upstream moved every command to backlog-js standalone functions (nulab#181), so the fork's comment paging in `issue comment --list` and `issue view --comments` now calls `getIssueComments(client, ...)` instead of the removed client method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backlog-jsin the workspace catalog from^0.20.1to^1.1.0./,?,#or..can no longer reach another endpoint. bee passes raw values and never encodes them itself, so nothing is double-encoded. A.or..segment now fails with aTypeErrorbefore any request is sent.@repo/backlog-utilscall backlog-js standalone functions instead ofBacklogmethods:client.getIssue(key)becomesgetIssue(client, key).getClientand the auth commands build the client withcreateClient, andBacklogClientis now backlog-js'sClient.const deleteIssue = new BeeCommand("delete")). Those files import the function under an alias (deleteIssue as deleteIssueApi).@repo/test-utils/mock-backlog-js, which follows themock-consolapattern. It forwards each backlog-js API function to the mock client's method of the same name, so existingmockClient.*stubs and assertions are unchanged. Each test file adds one line:vi.mock("backlog-js", () => import("@repo/test-utils/mock-backlog-js").then((m) => m.default)).The OAuth 401 retry Proxy in
getClientstill applies: the standalone functions callclient.get/client.post/ … on the Proxy, and the Proxy wraps those calls. Error objects in 1.x still have_name/_status/_response, so the duck-typed auth and rate-limit checks are unchanged.Test plan
vp checkvp test: 118 files, 792 tests passvp run --filter @nulab/bee build🤖 Generated with Claude Code