fix(deps): snakeyaml 2.4 (CVE-2022-1471 RCE) and aws-sdk 1.12.797 (removes ion-java) - #23
Conversation
…ion-java) - snakeyaml 1.33 -> 2.4 in core/http/thrift: clears the Constructor deserialization RCE (CVE-2022-1471), fixed only in the 2.x line. util-security's YAML usage survives the 2.x API change - validated by the midje suites. - aws-java-sdk-s3/core 1.12.261 -> 1.12.797 (thrift dev profile): 1.12.261 pulled software.amazon.ion:ion-java, whose coordinates are abandoned with no patched release for CVE-2024-21634; 1.12.797 dropped the ion-java dependency entirely. Verified: midje suites pass (core 114, http 34, thrift 13 checks); the thrift suite exercises the real S3 keystore download through aws-sdk 1.12.797. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Hi. 👋 I'm You can post a comment on this PR with one of the following commands: bookworm/release-it
I'll take care of updating CHANGELOG.md, bumping project.clj and merging this PR. Note: a stable version will be generated (that is Bumpito will update to it). bookworm/release-beta
I'll take care of generating a beta version based on these changes and bookworm/skip-releaseThis command should be used if you are changing something other than production code or docstrings that engineers can
I'll take care of merging this PR. If you have any problem, please reach my creators at #shared-libraries-and-tools |
There was a problem hiding this comment.
Pull request overview
This PR updates dependency pins across the finagle-clojure modules to resolve remaining fixable Dependabot security alerts, primarily by moving SnakeYAML to the 2.x line (for CVE-2022-1471) and updating the AWS Java SDK used by the thrift dev profile to remove the vulnerable ion-java artifact from the dependency tree.
Changes:
- Bump
org.yaml/snakeyamlfrom 1.33 → 2.4 incore,http, andthrift. - Bump
com.amazonaws/aws-java-sdk-s3andcom.amazonaws/aws-java-sdk-corefrom 1.12.261 → 1.12.797 in thethriftdev profile.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/project.clj | Pins SnakeYAML to 2.4 to address CVE-2022-1471 in the core module dependency tree. |
| http/project.clj | Pins SnakeYAML to 2.4 to address CVE-2022-1471 in the HTTP module dependency tree. |
| thrift/project.clj | Pins SnakeYAML to 2.4 and bumps AWS SDK S3/Core to 1.12.797 in the dev profile to eliminate ion-java. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Clears the last fixable Dependabot alerts (follow-up to #21/#22):
snakeyaml1.33 → 2.4 (core, http, thrift)util-security's YAML usage survives the 2.x API change — validated by the test suites.aws-java-sdk-s3/core1.12.261 → 1.12.797 (thrift dev profile)software.amazon.ion:ion-java, whose coordinates are abandoned (no patched release exists — the fix lives undercom.amazon.ion). 1.12.797 dropped ion-java entirely, so the vulnerable artifact leaves the tree.Validation
lein classpathconfirms snakeyaml 2.4 resolves in all three modules and ion-java is gone from thrift.After this merges, every remaining open alert is a justified dismissal (jackson CVE-2026-54515 with no patched release; libthrift capped at 0.12.0 by scrooge codegen compatibility, with the vulnerable TSSLTransport path unused since finagle-thrift does TLS via Netty).
🤖 Generated with Claude Code