Skip to content

color palette toggle phase 2 - set data- attributes - #217

Open
ntno wants to merge 34 commits into
feature/color-palette-togglefrom
feature/color-palette-toggle-phase-2
Open

color palette toggle phase 2 - set data- attributes#217
ntno wants to merge 34 commits into
feature/color-palette-togglefrom
feature/color-palette-toggle-phase-2

Conversation

@ntno

@ntno ntno commented Feb 3, 2026

Copy link
Copy Markdown
Owner
  • prepare bundled CSS palettes for data-scoping
  • set palette on html data- attribute

ntno added 30 commits January 31, 2026 23:04
@ntno
brainstorming
dc8b5fc
@ntno
documentation
a484b92
@ntno
add css var translation layer in theme.css
b913ce7
@ntno
update palettes with data attribute and scoped var names
f0e5ca6
@ntno
Merge branch 'feature/color-palette-toggle' into feature/color-palett…
d9a215e 
…e-toggle-phase-2
@ntno
use new data-palette option
d46dbbe
@ntno
make default palette work with new data scoping
a3949bd
@ntno
compatibility for inline link usage
a3d94a9
@ntno
hoist up default values to sans; document skipped edge case
3f806a9
@ntno
wip
d2c9485
@ntno
wip - initial palette template tests; todo: move these to new folder;…
8bfadcd 
… refactor js into separate file; fix failing tests
@ntno
notes on why inline script
fa1cb92
@ntno
refactor data attr
498a1af
@ntno
test wip
62301f9
@ntno
refactor
d384ca3
@ntno
test updates
eaf0ed5
@ntno
flake8 fixes
34ef7f5
@ntno
wip test results
d5e7647
@ntno
test wip
4736070
@ntno
wip
ac86516
@ntno
redesign css refactor
abea21a
@ntno
reduce duplication
e3d863b
@ntno
note refactoring
38c32f5
@ntno
test refactor - needs review
55b0915
@ntno
todos
c80ee6e
@ntno
test fix
2ab3d90
@ntno
test updates
5a20534
@ntno
target for fixing blank lines
8301dcd
@ntno
flake8 fixes
515c5cd
@ntno
notes
6a15a3a
@ntno ntno mentioned this pull request Mar 26, 2026
Open
@ntno
ntno marked this pull request as ready for review March 26, 2026 02:31
@ntno

ntno commented Mar 26, 2026

Copy link
Copy Markdown
Owner Author

@copilot review

Copilot AI commented Mar 26, 2026

Copy link
Copy Markdown

@copilot review

Reviewed. The main issue found was a cross-platform test failure: macOS's tidy (built from source via cmake) defaults to HTML 4.01 Strict validation and rejects data-* attributes on the <html> element, while Linux's apt-packaged tidy handles them without complaint.

Fixed in commit 2932a1b by:

  • Adding HTML5_DOCUMENT_OPTIONS = {"numeric-entities": 1, "drop-empty-elements": "no", "doctype": "html5"} to tests/utils/html.py
  • Updating test_base_template_attributes.py to use HTML5_DOCUMENT_OPTIONS (instead of ALLOW_EMPTY_ELEMENTS) when validating the full HTML5 document output from base.html

The rest of the changes look correct:

  • base.html: data-palette and data-available-palettes are properly set at build time from theme config
  • CSS palettes: all use [data-palette="name"] selectors with palette-prefixed constants in :root to avoid cross-palette variable collisions; legacy --background-color etc. aliases are preserved for backwards compatibility
  • theme.css: compatibility layer maps legacy names → namespaced vars with actual default fallbacks (no circular references)
  • styles.html: FOUC prevention script correctly runs synchronously before CSS links and validates saved palette against available options before applying

All 374 tests pass locally.

Copilot finished work on behalf of ntno March 26, 2026 02:40
ntno added 2 commits March 25, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ntno