Skip to content

Fix release signing setup and avoid duplicate CI runs - #8

Open
macro88 wants to merge 2 commits into
mainfrom
feat/ci-main-push
Open

macro88 wants to merge 2 commits into
mainfrom
feat/ci-main-push

Conversation

@macro88

@macro88 macro88 commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

The protected Android signing job failed during setup-node: its default automatic caching detects pnpm in package.json, but this job has no package manager installed. Disable automatic caching for that step so signing can proceed using Node built-ins and the Android tools.

Also restrict push-triggered CI to main, retaining pull-request and manual runs. This removes duplicate feature-branch runs while preserving the exact-main-commit CI prerequisite for release packaging.

Validation:

  • Executed the exact pinned setup-node bundle locally with Node 24.20.0 and pnpm absent: the default reproduces the missing-pnpm error; package-manager-cache: false succeeds.
  • Exercised the signing script against the built unsigned APK in an isolated fixture with a disposable RSA key, no pnpm and no installed dependencies. Signing, certificate verification, APK content/alignment checks and draft metadata all pass. Production credentials and public release creation were not exercised.
  • All 13 release regressions pass; workflow YAML and intended triggers validate. React Doctor and AISlop score 100/100; all ten dependency audits pass.

After merge and successful main CI, start a fresh manual release run to use the repaired workflow.

Copilot AI balanced review requested due to automatic review settings November 10, 2026 13:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@macro88 macro88 changed the title Avoid duplicate feature-branch CI runs Fix release signing setup and avoid duplicate CI runs Nov 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants