Skip to content

Put publisher and access first in napplet launch review - #3

Merged
macro88 merged 2 commits into
mainfrom
codex/napplet-launch-review
Nov 10, 2026
Merged

macro88 merged 2 commits into
mainfrom
codex/napplet-launch-review

Conversation

@macro88

@macro88 macro88 commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Changes

  • Share the trusted launch review between Discover and Settings. Put the signed app metadata, the signing publisher and requested access first.
  • Show required and optional capabilities separately. Explain unavailable access and keep Open and Cancel visible while the review scrolls.
  • Put the full publisher key, publication reference, signed event and verified artifact hashes in a collapsed Technical details section. Public profile and artwork lookups run independently of consent.
  • Update native review test selectors while keeping their exact release and access assertions.

Verification

  • TypeScript and 538 publication, Discover, shell, routing, identity and presentation tests passed.
  • 198 capability tests and 20 offline native driver checks passed. The Android and iOS routing core harnesses each passed 183 assertions. The updated Swift drivers compiled in the Simulator runner.
  • React Doctor and aislop both scored 100/100. All 10 dependency audits and the hosted CI run passed.
  • Three iPhone 17 Simulator tests and three Android emulator tests passed. Each platform covered Discover in light mode, Settings in dark mode and access to both actions at a larger text size. The Discover checks covered signed details, unavailable capabilities, approval, cancellation and the publisher key fallback.
  • The fixtures ran the PR's JavaScript with controlled publication and profile data. The iOS host used a fresh build with baseline iOS native inputs. The Android host reused the disposable landscape build and its unused fullscreen API. The temporary Simulator and emulator package were removed, and emulator settings were restored.

Copilot AI balanced review requested due to automatic review settings November 9, 2026 13:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@macro88
macro88 merged commit 5e46191 into main Nov 10, 2026
32 checks passed
@macro88
macro88 deleted the codex/napplet-launch-review branch November 10, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants