client/asset/eth: remove ineffectual brickedFailCount param#14
Open
norwnd wants to merge 1 commit into
Open
Conversation
norwnd
force-pushed
the
master
branch
4 times, most recently
from
ad9d264 to
e298e04
Compare
norwnd
force-pushed
the
master
branch
5 times, most recently
from
f9959eb to
a66bbae
Compare
norwnd
force-pushed
the
master
branch
3 times, most recently
from
e3c487c to
333e9f6
Compare
norwnd
pushed a commit
that referenced
this pull request
Apr 16, 2026
…ug fix
Batches the six easy/low-risk cleanup items from T18 into a single
commit, plus a related bug fix discovered during T18#10 research.
T18#6: DCR_ASSET_ID local constant -> shared DCRAssetID
- WalletsPage.tsx previously declared `const DCR_ASSET_ID = 42`
duplicating the existing `DCRAssetID` export in stores/types.ts.
Now imports from the shared location.
T18#13: dead createUpdater state in NewWalletForm
- Removed the `const [createUpdater] = useState(null)` line and its
associated `useNotifications({ createwallet })` handler. The
handler body had a `if (createUpdater) ...` null check on a
value that was always null, so the body never ran. Dead code
from an earlier refactor. Also removed the now-unused
WalletCreationNote and useNotifications imports.
T18#14: duplicate checkResponse helpers
- services/api.ts and hooks/useApi.ts both exported identical
`checkResponse` helpers. The canonical location is now
services/api.ts (where the related postJSON/getJSON/APIResponse
types live). Migrated 4 importers (DepositAddress,
WalletConfigForm, TokenApprovalForm, NewWalletForm) and deleted
the duplicate export from useApi.ts.
T18#4: returnPage typed as free-form string
- Added `type MMLogsReturnPage = 'mm' | 'mmarchives'` to
router/routes.ts. MMLogsPage now narrows the raw query-param
string via the union type, and MMArchivesPage assigns through a
typed local constant. Prevents typos from silently falling
through to the default 'mm' on either side of the producer/
consumer boundary.
T18#9: icon-only link a11y in SetVotesModal
- Added `aria-label={tspend.hash.slice(0, 8)... in block explorer}`
to the tspend explorer `<a>` (was a bare `ico-open` anchor with
no accessible text) and `aria-label={View proposal: ${name}}`
to the proposal `<Link>`. Both elements are icon-only so screen
readers had no fallback text before this change. Matches vanilla's
visual behavior; vanilla has the same a11y gap.
T18#10: proper TransactionNote type (+ B-L16 dispatch bug fix)
- BridgingPopup's handleTransactionNote previously cast the
incoming note to an ad-hoc `{ transaction?: { id, timestamp } }`
shape. Replaced with the existing `TransactionNote` type from
stores/types.ts.
- Discovered a REAL BUG during the type audit: the popup was
subscribing to a top-level `transaction` note type that does
not exist. Vanilla's dispatch flow wraps these inside
`walletnote` (CoreNote with type='walletnote' and
payload.route='transaction'); see wallets.ts L2767
`handleCustomWalletNote` + L2791 `case 'transaction'`. So my
handler never fired. Fixed by subscribing to `walletnote:`
instead and unwrapping the payload inline. The cosmetic
timestamp-refresh behavior that was silently broken now works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing I discovered this
brickedFailCountdoesn't really have any effect becausetip.failCountgets reset to0before ever reaching it, andfailQuarantineis probably does the job on its own anyway.