Repository navigation
feat(webhooks): payments.webhook.received event typed as the payment fact - #95
Merged
Merged
Conversation
…ized payment fact (PaymentFactDto), provider ids on event.metadata.payment, docs
Every payment provider callback reaches a Norbix webhook destination as one
event, payments.webhook.received (gateway campaign audit/payments, decision
D1). The receiver now knows the name (NorbixWebhookEvents.Payments.WebhookReceived,
the catalog and the groups), types the payload as the generated
PaymentFactDto (same fields the gateway sends), and lifts integrationId and
{ provider, providerEventId, eventName } onto event.metadata.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Release previewNext version on merge to semantic-release dry-run output
|
|
🎉 This PR is included in version 4.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the payments webhook event to
@norbix.ai/ts/webhooks.payments.webhook.receivedinNORBIX_WEBHOOK_EVENT_NAMES,NorbixWebhookEvents.Payments.WebhookReceivedand the event groups.CodeMashHub2.PaymentFactDto(generated type; the same fields the gateway delivers — no hand-written DTO).event.metadata.payment = { provider, providerEventId, eventName }andmetadata.integrationId.docs/webhooks-receiver.md→ Payments section.Tests:
vitest run64 files / 1049 tests passed; type test for the payload; receiver test with the delivery shape the gateway L4 testPaymentsTriggerFiresWebhookE2ETestsproduces.Gateway side: campaign
audit/payments(codemash-io/gateway, branch audit/payments), trackerdocs/testing/testing-plan/10-payments/status.md, item 7.Expected release: minor (new event, no breaking change).
🤖 Generated with Claude Code