Repository navigation
feat(payments): payment integration types without webhook secrets; in-app webhook ids required - #100
Merged
Merged
Conversation
…-app webhook ids required Regenerated the Hub types (hub2.dtos.ts, hub2.contract.json) from gateway refactoringV2 fc5f424b5. Get payment integration no longer returns stored webhook secrets. The Apple / Google in-app requests now need only the webhook identity; the Apple Pay / Google Pay merchant fields are optional. Also picks up Hub types already on refactoringV2: team member and invitation management, environment promotion preview / integration choices, built-in repair, endUserOwnRecords report, team push devices. Breaking: Get payment integration no longer returns webhookSecret / webhookSignatureKey; Apple/Google in-app saves need webhookBundleId / webhookPackageName, the Apple Pay / Google Pay fields are optional. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Release previewNext version on merge to semantic-release dry-run output
|
vite 8.3.2 has GHSA-587h-7wmj-h5pm (high), GHSA-698v-4r3x-3vcv and GHSA-r825-w8mm-5pxw; the OSV scan in CI fails on them. Same lockfile change as Dependabot #99. Dev-only, not shipped in @norbix.ai/ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🎉 This PR is included in version 4.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerated the Hub types (
src/types/hub2.dtos.ts,src/types/hub2.contract.json) from gatewayrefactoringV2fc5f424b5 (payments security fix: Get payment integration returned stored webhook secrets).Payments contract changes
Worldpay/Shopify/WooCommerce/Magento/Braintree/CheckOutComPaymentIntegrationDto:webhookSecretremoved;AuthorizeNetPaymentIntegrationDto:webhookSignatureKeyremoved.AppleInAppPaymentIntegrationRequest:webhookBundleIdrequired; merchant identifier / domain / display name and the two certificate + password fields optional.AppleInAppPaymentIntegrationDto: all optional, addswebhookBundleId.GoogleInAppPaymentIntegrationRequest:webhookPackageNamerequired;merchantId,merchantName,gateway,privateKeyOrTokenoptional.GoogleInAppPaymentIntegrationDto: all optional, addswebhookPackageName.WorldpayPaymentIntegrationRequest.webhookSecretrequired.Also picked up (already on refactoringV2): team member / invitation management (
UpdateTeamMember,RemoveTeamMember,SetTeamMemberRoleEnvironmentsRequest,GetAccountTeamInvitations,CancelTeamInvitation), promotion preview and integration choices (PromotionResultDtosummary/items/integrations,confirmRecordLoss,integrationChoices),RepairEnvironmentBuiltInsRequest,EndUserOwnRecordsReportRequest,GetPushDevicesResponse.teamDevices. Types only; no SDK methods added in this PR.No SDK source, test or doc referenced the removed fields. Checks:
npm run typecheck,npm run typecheck:dist,npx vitest run(65 files, 1068 tests),npm run lint,npx prettier --check .all green.Second commit:
chore(deps-dev)bumps vite 8.3.2 → 8.3.4 in the lockfile (same change as Dependabot #99) because the CI OSV scan fails on vite 8.3.2 advisories (GHSA-587h-7wmj-h5pm and two others). Dev-only.Breaking: Get payment integration no longer returns webhookSecret / webhookSignatureKey; Apple/Google in-app saves need webhookBundleId / webhookPackageName, the Apple Pay / Google Pay fields are optional.
🤖 Generated with Claude Code