Repository navigation
test(templates): clone returns the new copy's id - #64
Merged
Merged
Conversation
clone_email_template, clone_sms_template and clone_push_template already
return whatever the Hub answers. The gateway now answers an IdResponse
({"id": "..."}) for the three clone requests, so the docstrings and the
notifications page say so, with an example.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
One test per clone method (email, SMS, push) and one async: a fake
transport answers {"id": "tpl_copy"} and the caller gets it back.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Domantas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Template clone answers the new copy's id
The gateway (refactoringV2 dcacb2fd2, 650817c07) now answers
IdResponse({"id": "…"}) for CloneEmailTemplateRequest, CloneSmsTemplateRequest and ClonePushTemplateRequest (was EmptyResponse). Additive on the wire.clone_email_template,clone_sms_templateandclone_push_template(sync and async) already return whatever the Hub answers, so no code changes:{"id": "..."}; docs/hub/notifications.md gets a "Cloning a template" section with an example.{"id": "tpl_copy"}and the caller gets it back.No references/ folder (removed 2026-10-22), nothing to regenerate. Commit types are docs + test, so no release by design.
Tests: ruff clean, mypy clean, pytest 1168 passed.
Not in this PR (finding for a later Routine D): the gateway now also serves routes this SDK has no method for yet — DeletePushDevice (DELETE /{version}/notifications/push/devices/{Id}), GetEnvironmentAdminUrl / UpdateEnvironmentAdminUrl (GET / PATCH /{version}/account/projects/environments/{environmentName}/admin-url) and SendTestPasswordResetRequest (POST /{version}/membership/userauth/password/reset/test, Api).
🤖 Generated with Claude Code