Repository navigation
feat(logs): write_logs on api.logs and the missing hub log routes - #59
Merged
Merged
Conversation
- api.logs.write_logs(entries=[...]) — POST /{version}/logs on the Api
(sync and async; also NorbixApi.logs).
- hub.logs: get_logs, get_log, clean_logs, get_log_settings,
save_log_settings (finding L12), verbs checked against the manifest.
- save/test logging integration docstrings say nothing is delivered until
the last test passed (L29).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…integration Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logs campaign, item 6 (Python SDK).
api.logs.write_logs(entries=[...])—POST /{version}/logson the Api (sync + async, alsoNorbixApi.logs).hub.logsgains the missing routes (finding L12):get_logs,get_log,clean_logs,get_log_settings,save_log_settings. Every logs verb checked against the gateway manifest (enable/disable are PUT — L22 stays fixed).docs/api/logs.md(fields, limits, refusals incl. 429CM-ERRORS-LOGGING-003);docs/hub/logs.mdlists all 15 routes and says to calltest_logging_integrationafter saving an integration — nothing is delivered until its last test passed (L29).Tests:
make checkgreen — ruff, mypy, pytest 1150 passed (1137 before, +13 new).Expected release: v3.27.0 (minor).
🤖 Generated with Claude Code