Repository navigation
feat(code): no default Code integration; runs carry the Fake input - #47
Merged
Merged
Conversation
Gateway contract refactoringV2 b2303b4d8: the route
PUT /{version}/code/integrations/{Id}/default (SetCodeIntegrationAsDefault),
GetCodeIntegrationsResponse.defaultIntegrationId and
CodeDto.defaultIntegrationViewId are gone; CodeFunctionRunDto.input (the
scrubbed envelope a Fake-provider run received) is new;
GetCodeFunctionEventSample.source binds in any case.
Hub reference DTOs regenerated with the ServiceStack `x` tool (the refresh
also picks up GetLicenseKey / GetLicenseKeyResponse from gateway 3fa02078e;
no method added). The set-default method, its tests and docs rows removed;
the runs docs mention `input`. Pass the integration id everywhere instead.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Gateway contract
refactoringV2b2303b4d8: there is no default Code integration any more — the routePUT /{version}/code/integrations/{Id}/default(SetCodeIntegrationAsDefault),GetCodeIntegrationsResponse.defaultIntegrationIdandCodeDto.defaultIntegrationViewIdare gone;CodeFunctionRunDto.input(string, the scrubbed envelope a Fake-provider run received) is new;GetCodeFunctionEventSample.sourcebinds in any case.references/hub_dtos.pyregenerated with the ServiceStackxtool against the gateway at b2303b4d8 (hub only; the api reference is left alone — known gap C22). The refresh also picks upGetLicenseKey/GetLicenseKeyResponse(GET /{version}/account/licenses/{Id}/key, gateway 3fa02078e); no method added for it.hub.code.set_code_integration_as_default(sync and async) removed fromsrc/norbix_python/hub/code.py; its surface assert and request-shape test removed;docs/hub/code.mdrow removed.input; the event-sample row sayssourceis accepted in any case.Breaking: the set-default method is removed — pass the integration id everywhere (
functionRef.integrationIdon trigger actions, scheduler tasks and manual invokes). Released as a minor.Tests
uv run pytest: 1093 passed (was 1094; −1: the removed request-shape test).make typecheck(uv run mypy src): clean, 39 source files.Context
gateway docs/tasks/code-functions.md (branch refactoringV2), steps 10–12; itemdocs/testing/testing-plan/11-code/items/sdk-secondary-no-default.md.🤖 Generated with Claude Code