Repository navigation
feat(push): get_push_devices and get_push_device, sync and async - #14
Merged
Merged
Conversation
… field names Squash of audit/push-sdk-go-js-py (campaign item sdk-go-js-py). The body-variant tests only proved that a body reached the wire unchanged, so a wrong value still passed. They now send and assert every field the gateway actually reads for each variant, and a guard test fails if a target or provider is not one the gateway accepts. A device-register body test was added, and docs/hub/push.md lists the own fields per provider and per target. This caught a real defect: the Chrome-extension provider was tested and documented as CodeMashChromePlugin. That string parses as a PushProvider, but the gateway save converter (Hub.Push/Integrations/Save_.cs:94-121) has no arm for it and answers "Unsupported provider". The value is ChromePush. Anyone following the old docs could not save a Chrome-extension integration. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…and async, 37 -> 39 routes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
get_push_devices(filter byuserId,deviceKeyorplatform— a page is a page of users, followhasMore) andget_push_device(id), on the sync and the async client. Routes 37 → 39.main; no type files in this SDK (requests are dicts).Tests
pytest615 passed (push: 60).Merging
Please use Squash and merge, so semantic-release reads this title as the one commit: the branch's own commits are titled
item: …/test(push)and would not publish on their own.🤖 Generated with Claude Code