Repository navigation
fix(hub): hub and api keep --host; the test provider is called Sandbox - #83
Merged
Merged
Conversation
…l flags The generic commands split their argv by a hand-kept list of global flags that missed --host, --language and --prod, so --host became a request field and the call went to the [default] profile's host. The list is now derived from BaseCommand.baseFlags plus the command's own flags, and host discovery in init() parses the same split argv (and gives oclif's overwritten argv back), so it runs for the --host target. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`email|sms|push integration save --provider Sandbox` replaces `--provider Fake`; the request still carries the API value `Fake`. Help, examples, `code runs` texts and the docs pages say Sandbox: the safe built-in provider that accepts every send and never contacts a real service. Breaking: `--provider Fake` is no longer offered; use `--provider Sandbox`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🎉 This PR is included in version 1.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
norbix hub/norbix apidropped--host(and--language,--prod): the hand-kept list of global flags missed them, so--hostbecame a request field and the call went to the[default]profile's host. The list is now derived fromBaseCommand.baseFlags+ the command's flags, and host discovery ininit()parses the same split argv (restoring the argv oclif overwrites).code runstexts and docs;--provider Sandboxsends the API valueFake. Breaking:--provider Fakeis no longer offered.Tests:
npm test38 files / 1037 tests green. Newtests/namespace-host.test.ts(6 tests) fails on origin/main and passes here.Task file: docs/tasks/host-flag-and-sandbox.md (branch fix/host-flag). Expected release: minor.
🤖 Generated with Claude Code