Repository navigation
fix(triggers): a trigger file saved from trigger --json keeps its action - #81
Merged
Merged
Conversation
…its action The read answer wraps the trigger in `item` and names the action `thenAction`; the save request wants `action`. `payments trigger save` and `db trigger create` now unwrap `item` and rename `thenAction`, so read → edit → save no longer saves a trigger without an action (found by the payments docs work, campaign audit/payments). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🎉 This PR is included in version 1.34.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
payments trigger saveanddb trigger createtake atrigger <id> --jsonanswer as their--file: theitemwrapper is unwrapped andthenActionis saved asaction. Before this, a read → edit → save round trip saved a trigger with no action.src/lib/triggers.ts(triggerFromFile); one round-trip test each intests/payments-routes.test.tsandtests/db-routes.test.ts.Tests:
vitest run37 files / 1028 passed;tsc --noEmitclean.Found by the payments docs work (gateway campaign
audit/payments, item 12). Expected release: patch.🤖 Generated with Claude Code