Repository navigation
feat(docker): community admin image with runtime PROJECT_ID - #13
Merged
Merged
Conversation
The Dockerfile has no VITE_ADMIN_RELEASE arg and no code reads it: the edition comes from the Hub's /echo at runtime, so managed, enterprise and community are the same build. Exclude env variants, keys, tests, test artefacts, .next and other non-build files from the public image context. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NEXT_PUBLIC_ADMIN_PROJECT_ID is inlined at build time, so a public image could not serve a customer's project on a custom domain. The root layout now reads PROJECT_ID from the server env per request and emits it as the norbix-project meta tag the client resolver already reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community admin image for self-hosted installs (published later as docker.io/norbix/community-admin).
.dockerignorehardened: every.env*, keys, tests,.next, tooling — Next bakesNEXT_PUBLIC_*from.env*at build time.PROJECT_IDenv (server reads it per request, emits<meta name="norbix-project">), so one public image works on any customer domain.VITE_ADMIN_RELEASEbuild arg from the workflows — the edition is read at runtime from the Hub/echo.Tests: lint 0, tsc 0 errors, vitest 124/124,
next buildOK; amd64 image 78 MB, scan: no.env*, keys,*.mapor test files; container smoke test with and withoutPROJECT_ID.Task file: docs/tasks/community-admin-image.md (branch feat/community-admin-image).
🤖 Generated with Claude Code