Repository navigation
feat(branding): project name and logo in the portal shell, auth screens and tab title - #10
Merged
Merged
Conversation
…portal Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d on every auth screen, tab title = project name Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…resent, applyBranding title/favicon/tokens Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… spec with sign-in and shell goldens Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…erence Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AppLayout): shows the project logo (alt= project name) when the public config haslogoUrl, else the project name. The old hard-coded "Account" shows only while no project name is known. The "Account" label of the sign-out menu at the bottom stays.brandName+logoUrlfrom the store toAuthLayout, like sign-in already did.applyBrandingsetsdocument.titleto the project name. The static metadata title "Admin Portal" stays as the fallback before the config loads.projectNameOf()inprojectConfig.ts: the project name, or nothing while only the "Sign in" placeholder is known, so the sidebar and the tab never say "Sign in".dashboard.tsx"Norbix Admin" is left as is: it is the no-project placeholder, there is no name to show there.Tests
src/config/projectConfig.branding.test.ts(12 tests) covers the public-config mapping (name fallback order, brand absent / present, empty logo, endpoint failure),projectNameOf, andapplyBranding(title, favicon, colour tokens).brandingblock (logo + icon, no colours). Newtests/e2e/branding.spec.ts: sign-in shows the logo + "Sign in to E2E Shop", password reset shows the logo, the signed-in shell shows the logo in the sidebar, and the tab title is the project name.Results
npm run lintpass,npm run format:checkpassnpm test13 files, 92 tests passnpm run test:e2e6 / 6 pass. The existing chat goldens did not change.npm run typecheck: 6 errors, all inside../sdks/norbix-react-redux(it callsgetEmailCampaignMessageetc., whichnorbix-jsmain does not have). The same 6 errors happen onmainwithout this change. No errors insrc/.Screenshots (new goldens)
tests/e2e/branding.spec.ts-snapshots/branding-sign-in-chromium-darwin.pngtests/e2e/branding.spec.ts-snapshots/branding-shell-chromium-darwin.pngTask file with findings:
docs/tasks/project-branding.md.🤖 Generated with Claude Code