Skip to content

docs(skills): add undo and history workflows - #82

Merged
dobleuber merged 1 commit into
nsolid-console-7from
docs/mcp-undo-history-workflows
Nov 3, 2026
Merged

dobleuber merged 1 commit into
nsolid-console-7from
docs/mcp-undo-history-workflows

Conversation

@dobleuber

Copy link
Copy Markdown

Existing N|Solid undo and history tools were missing from the skill workflows. This adds safe restoration and early unsilencing, config-history inspection, reconnect investigation and bounded sourcemap-set inspection. Restore and reconnect requests now route to the relevant workflows, while existing user authorization remains effective.

Validation on Node 22.23.2 / pnpm 9.15.9:

  • pnpm plugin:check and pnpm --dir packages/core skills:check
  • pnpm lint, pnpm typecheck, pnpm build
  • Product-name unit test: 1 passed, none skipped
  • Native Claude /review and codex review completed on this full range; candidates independently checked against the server contracts. No new blocking defect confirmed.

@ns-control-tower

ns-control-tower commented Nov 2, 2026 •

Copy link
Copy Markdown

Walkthrough

Documentation-only change: five skills/*/SKILL.md files now route and document the N|Solid undo/history flows that were missing.

Skill Change
ns-analyze-asset New Restoring a Deleted Asset section (:127) — deleted-asset paging, undoUntil deadline, restore_asset + nsolid:manage-assets, 410 handling, pinned-budget note — plus a routing line (:11) and guardrail (:137).
ns-analyze-event New drop/reconnect entry path (:9), connect added to the lifecycle list_events types (:31), agent_sessions guidance (:33).
ns-analyze-release Bounded get_sourcemap_set inspection — entries ≤ 200, path/mapsMatched/mapsOmitted (:56).
ns-configure-agents desired_config_history inspection — 50 newest saves/deletes, no restore tool (:14).
ns-manage-alerts unsilence_alert flow (:96) + guardrail/permission updates (:4, :103).

Each edit pairs a frontmatter description update (routing) with workflow steps and, where relevant, consent guardrails.

Assessment

  • No blocking findings, no inline comments. Cross-references resolve: ns-analyze-asset "steps 2–10" and the #restoring-a-deleted-asset anchor match the file's structure; ns-analyze-event "Lifecycle in step 2" and the connect type match step 1's event-type list; ns-configure-agents "preview and apply it as below" resolves to steps 2–4.
  • Consistency: repo greps show the new tool names and section text appear only in the updated files; no stale copies of skill files exist elsewhere in the repo.
  • Validation at reviewed head ae878be: CI run 41542112597 (test: lint/build/test on Linux/macOS/Windows) succeeded; locally plugin:sync --check, plugin:root:check, and skills:check all pass.
  • Safety: the guidance tightens behavior (restore needs an explicit user ask; unsilence needs the user's say-so; set deletion stays UI/API-only) and adds no executable code.
  • MCP tool-contract details (page sizes, limits, field names) live on the N|Solid MCP servers, not in this repo; the PR states candidates were checked against server contracts.

Verdict: APPROVE — docs-only change; cross-references resolve, content is internally consistent, CI and repo sync checks pass at the reviewed head.

@dobleuber dobleuber self-assigned this Nov 2, 2026
@dobleuber
dobleuber marked this pull request as ready for review November 2, 2026 23:18

@brycebaril brycebaril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this matches the MCP server's tools. Checked:

  • agent_sessions takes no from/to, and connect is a valid list_events type.
  • list_assets has no cursor, so pointing to GET /v1/tenants/{tenant}/assets with cursor and its agent filter is right.
  • restore_asset needs Keeping files (nsolid:manage-assets), and unsilence_alert needs nsolid:manage-alerts. A 410 after undoUntil is final.
  • desired_config_history returns the 50 newest saves and deletes, and no tool restores an old version. So "make it a new change, then preview and apply it" is the right way back.

CI is green on all three platforms.

@dobleuber
dobleuber merged commit 7ab7b66 into nsolid-console-7 Nov 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants