Repository navigation
feat(nsolid): ns-analyze-behaviors explains a capability the package's code never imports, and calls from code it compiled from a string #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brycebaril
wants to merge
4
commits into
nsolid-console-7
Choose a base branch
from
behaviors-not-in-code
base: nsolid-console-7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7ef555f
feat(nsolid): ns-analyze-behaviors explains a capability the package'…
brycebaril 1c68a46
fix(nsolid): ns-analyze-behaviors doesn't explain a notInScan mark by…
brycebaril 596d50c
feat(nsolid): ns-analyze-behaviors explains calls made from code comp…
brycebaril 2e113e2
fix(nsolid): ns-analyze-behaviors doesn't name a compiled call's comp…
brycebaril File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Limit compiled to at least one observed call
The behavior-level
compiledflag is true if any observed call came from string-compiled code; it does not apply to every entry inmodulesorfunctions. The aggregation retains all function names while combining the flag with a maximum/OR.I reproduced a single package version with a generated
node:fs.readFileSynccall and an ordinarynode:fs.writeFileSynccall. Both functions belong to the same capability record, which hascompiled: true. Saying "the calls came from code compiled from a string" can therefore make the analyst attribute both calls to generated code and explain away an ordinary call as expected template activity.Please say that at least one observed call came from string-compiled code, and clarify that this flag alone does not identify which listed calls came through generated code.