Skip to content

test: fix X.509 generation with OpenSSL 4.1 FIPS - #67409

Closed
panva wants to merge 1 commit into
nodejs:mainfrom
panva:fix-x509-generate-fips
Closed

panva wants to merge 1 commit into
nodejs:mainfrom
panva:fix-x509-generate-fips

Conversation

@panva

@panva panva commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Use a passphrase that meets the 4.1 FIPS provider's minimum for PBKDF2.

Fails on main because #67245 and #67248 landed independently.

Use a passphrase that meets the FIPS provider's minimum for PBKDF2.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 11, 2026

@gurgunday gurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 11, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 11, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

panva added a commit that referenced this pull request Nov 11, 2026
Use a passphrase that meets the FIPS provider's minimum for PBKDF2.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #67409
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
@panva

panva commented Nov 11, 2026

Copy link
Copy Markdown
Member Author

Landed in b6d6c6c

@panva panva closed this Nov 11, 2026
@panva
panva deleted the fix-x509-generate-fips branch November 11, 2026 13:41
@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.69%. Comparing base (1b99d7c) to head (d038746).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67409      +/-   ##
==========================================
- Coverage   90.70%   90.69%   -0.02%     
==========================================
  Files         801      801              
  Lines      281559   281559              
  Branches    54248    54242       -6     
==========================================
- Hits       255387   255357      -30     
- Misses      16308    16350      +42     
+ Partials     9864     9852      -12     

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95 pushed a commit that referenced this pull request Nov 11, 2026
Use a passphrase that meets the FIPS provider's minimum for PBKDF2.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #67409
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants