Repository navigation
Conversation
Conversion failures can currently look like absent certificate fields. Invalid validity times produce "Bad time value" or Invalid Date, so date comparisons can fail without reporting the invalid input. Throw for failed field conversion, certificate encoding, fingerprint calculation, and decoding of present AIA or EKU extensions. Stop legacy certificate conversion at the first error. Report failed or unsupported private-key comparisons separately from a key mismatch. In verify(), throw on negative verification results except for a wrong key type or invalid unused bits in the signature BIT STRING. Those cases and a zero verification result return false. Fixes: nodejs#67285 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
panva
added
the
semver-major
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Member
Author
|
Blocked on #67406 landing first. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67408 +/- ##
==========================================
- Coverage 90.70% 90.69% -0.01%
==========================================
Files 801 801
Lines 281559 281603 +44
Branches 54248 54262 +14
==========================================
+ Hits 255387 255406 +19
- Misses 16308 16332 +24
- Partials 9864 9865 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conversion failures can currently look like absent certificate fields. Invalid validity times produce "Bad time value" or Invalid Date, so date comparisons can fail without reporting the invalid input.
Throw for failed field conversion, certificate encoding, fingerprint calculation, and decoding of present AIA or EKU extensions. Stop legacy certificate conversion at the first error.
Report failed or unsupported private-key comparisons separately from a key mismatch. In verify(), throw on negative verification results except for a wrong key type or invalid unused bits in the signature BIT STRING. Those cases and a zero verification result return false.
Fixes: #67285