Repository navigation
Conversation
nodejs-github-bot
added
c++
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
When copying files with preserveTimestamps: true, CopyUtimes previously converted the source timespec integers into an IEEE-754 double of seconds before calling uv_fs_utime. At current epoch values, this resulted in sub-millisecond precision loss. If the original nanoseconds sat near a half-millisecond boundary, the loss caused the JS destination millisecond to round differently than the source. This commit uses utimensat directly on POSIX to pass the exact tv_sec and tv_nsec integers from the source file to the destination, avoiding the floating-point conversion. Fixes: nodejs#66861 Signed-off-by: Mohamed Ahmed <mwhamd345@gmail.com> Assisted-by: Antigravity <antigravity@google.com>
hazalkoom
force-pushed
the
fix-66861-cp-sync-mtime
branch
from
November 11, 2026 08:40
ecc854f to
db4f5fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When copying files with preserveTimestamps: true, CopyUtimes previously converted the source timespec integers into an IEEE-754 double of seconds before calling uv_fs_utime. At current epoch values, this resulted in sub-millisecond precision loss. If the original nanoseconds sat near a half-millisecond boundary, the loss caused the JS destination millisecond to round differently than the source.
This commit uses utimensat directly on POSIX to pass the exact tv_sec and tv_nsec integers from the source file to the destination, avoiding the floating-point conversion.
Fixes: #66861
Assisted-by: Antigravity antigravity@google.com