Repository navigation
Conversation
Collaborator
|
Review requested:
|
When an unquoted value was empty but followed by spaces or tabs, as in `KEY= `, the parser trimmed the newline along with the whitespace and took the next line as the value. Strip only spaces and tabs before checking for an empty value. Fixes: nodejs#67400 Assisted-by: Claude Code Signed-off-by: TseIan <tseianxwc@gmail.com>
Tseian
force-pushed
the
fix/dotenv-empty-value
branch
from
November 11, 2026 08:51
6af616a to
8faa050
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67404 +/- ##
==========================================
- Coverage 90.74% 90.73% -0.02%
==========================================
Files 798 798
Lines 280102 280104 +2
Branches 53901 53900 -1
==========================================
- Hits 254186 254147 -39
- Misses 16198 16250 +52
+ Partials 9718 9707 -11
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an unquoted value is empty but followed by spaces or tabs
(
KEY=), the dotenv parser trimmed the newline together with thewhitespace and took the next line as the value:
Strip only spaces and tabs before checking for an empty value. This
affects both
util.parseEnv()and--env-file.Fixes: #67400
🤖 Generated with Claude Code