Repository navigation
node-api: reject detaching immutable arraybuffers - #67388
Open
fatihguzeldev wants to merge 1 commit into
Open
fatihguzeldev wants to merge 1 commit into
fatihguzeldev wants to merge 1 commit into
Conversation
return napi_detachable_arraybuffer_expected for immutable arraybuffers instead of aborting when v8 rejects the detach operation. Refs: nodejs#66346 Signed-off-by: Fatih Güzel <fatihguzeldev@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67388 +/- ##
==========================================
- Coverage 92.62% 90.72% -1.91%
==========================================
Files 430 798 +368
Lines 196333 280076 +83743
Branches 29897 53886 +23989
==========================================
+ Hits 181849 254089 +72240
- Misses 14159 16276 +2117
- Partials 325 9711 +9386
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
napi_detach_arraybuffer() aborts when passed an immutable arraybuffer.
return napi_detachable_arraybuffer_expected instead.
Refs: #66346